commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [compress] Bugs fixed - review and release?
Date Mon, 27 Apr 2009 19:46:25 GMT
On 27/04/2009, sebb <sebbaz@gmail.com> wrote:
> On 27/04/2009, Christian Grobmeier <grobmeier@gmail.com> wrote:
>
> > > Just remembered - what about ZipArchiveInputStream.useUnicodeExtraFields?
>  >  > This field is currently unused - what are the plans for it?
>  >  > Maybe just add a JIRA so it is not overlooked?
>  >
>  >
>  > yes, definitly!
>  >  I found before a few days and forgot about it agian. Will create ticket for it.
>  >
>  >  I have update the code with your suggetsions above.
>
>
> OK, but I think there need to be some more test cases. I'll try to add
>  some shortly.

OK, I've added some more tests, which currently cause failures as
there is no checking for closeArchiveEntry() before putArchiveEntry().

There are also some other failures if that part of the test is
disabled. Not yet looked at fixing these.

>
>  >  In Tar and Zip i
>  >  allowed some more method calls at the moment. I would have to modify
>  >  signature.
>
>
> Which signature is that?
>
>
>  >  Have you time to review it?
>
>
> Sorry, I don't follow - review what?
>
>
>  >  Cheers
>  >
>  > Christian
>  >
>  >
>  >  ---------------------------------------------------------------------
>  >  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  >  For additional commands, e-mail: dev-help@commons.apache.org
>  >
>  >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message