commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [compress] Bugs fixed - review and release?
Date Mon, 27 Apr 2009 17:52:25 GMT
On 27/04/2009, Christian Grobmeier <grobmeier@gmail.com> wrote:
> > The only minor issue I have is with finish() and close().
>  > I think it is going to be annoying for users to have to call finish()
>  > separately from close().
>  >
>  > I would prefer to see finish() being optional, i.e. close() should
>  > call it if necessary.
>  >
>  > But the code should check to make sure that finish() is not called
>  > twice, and maybe should check that only close() - and write() - is
>  > allowed after calling finish().
>
>
> sounds good!
>  +1 from my side too
>

Just remembered - what about ZipArchiveInputStream.useUnicodeExtraFields?
This field is currently unused - what are the plans for it?
Maybe just add a JIRA so it is not overlooked?

>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message