commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r763196 - /commons/sandbox/runtime/trunk/src/main/native/include/arch/windows/acr_arch.h
Date Wed, 08 Apr 2009 12:54:57 GMT
On 08/04/2009, Mladen Turk <mturk@apache.org> wrote:
> sebb wrote:
>
> >
> > >  +    SYSDLL_JVM          = 6,    // jvm      From our own jvm.dll
> > >  +    SYSDLL_defined      = 6     // must define as last idx_ + 1
> > >
> >
> > Shouldn't that be 7 then? Or does the JVM value not count?
> >
> >
>
>  Yes. Thanks for keeping an eye ;)
>
>  However this is still in early stage of merging
>  few existing code bases, so it'll take at least
>  two weeks before someone should take a serious look ;)

Point taken, but it jumped out at me as a possible error so I thought
I'd record it in case it got forgotten.

>  I could dump all at once, but then the cleanup
>  would be needed, and this approach gives more
>  sense to SVN log thought.
>
>  Regards
>  --
>  ^(TM)
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message