Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 31459 invoked from network); 2 Mar 2009 16:14:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Mar 2009 16:14:16 -0000 Received: (qmail 40924 invoked by uid 500); 2 Mar 2009 16:14:14 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 40852 invoked by uid 500); 2 Mar 2009 16:14:14 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 40841 invoked by uid 99); 2 Mar 2009 16:14:14 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Mar 2009 08:14:14 -0800 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [88.84.142.181] (HELO samaflost.de) (88.84.142.181) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Mar 2009 16:14:07 +0000 Received: from localhost (unknown [127.0.0.1]) by samaflost.de (Postfix) with ESMTP id DB02AE220014 for ; Mon, 2 Mar 2009 16:13:46 +0000 (UTC) Received: from samaflost.de ([127.0.0.1]) by localhost (v30161.1blu.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 22388-02 for ; Mon, 2 Mar 2009 17:13:45 +0100 (CET) Received: by samaflost.de (Postfix, from userid 2525) id 6B12AE22000A; Mon, 2 Mar 2009 17:13:45 +0100 (CET) To: dev@commons.apache.org Subject: Re: [compress] [PATCH] Refactoring of zip encoding support. X-Draft-From: ("nnfolder:mail.jakarta-lib" 122976) References: <49AAFDC5.80704@ev-i.at> From: Stefan Bodewig Date: Mon, 02 Mar 2009 17:13:45 +0100 In-Reply-To: <49AAFDC5.80704@ev-i.at> (Wolfgang Glas's message of "Sun\, 01 Mar 2009 22\:27\:33 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: amavisd-new at samaflost.de X-Virus-Checked: Checked by ClamAV on apache.org On 2009-03-01, Wolfgang Glas wrote: > 1) Unicode extra fields are written for all ZIP entries and not only > for entries, which are not encodable by the encoding set to > ZipArchiveOutputStream. Maybe room for yet another flag? Or an enum-like option setCreateUnicodeExtraFields(NEVER | ALWAYS | NOT_ENCODABLE) ? I've commented out that part of your patch. > To overcome these shortcoming, I had to introduce a ZipEncoding > interface plus a java.nio implementation and a handcrafted > implementation for Cp437 (and cp850) and refactor all the encoding > stuff. Looks good. > The patch is attached. The new code is IMHO really better to read > and make all cp437-related stuff accessible on java-1.4 as well. Agreed, many thanks! > Stefan, might you please review the patch and eventually apply this one? some cosmetics and commented out the "only create Unicode field for non-encodable paths" part - svn revision 749342. Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org