Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 74480 invoked from network); 31 Mar 2009 13:22:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 31 Mar 2009 13:22:32 -0000 Received: (qmail 49537 invoked by uid 500); 31 Mar 2009 13:22:31 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 49429 invoked by uid 500); 31 Mar 2009 13:22:31 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 49419 invoked by uid 99); 31 Mar 2009 13:22:31 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Mar 2009 13:22:31 +0000 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [88.84.142.181] (HELO samaflost.de) (88.84.142.181) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Mar 2009 13:22:25 +0000 Received: from localhost (unknown [127.0.0.1]) by samaflost.de (Postfix) with ESMTP id E81C4E220014 for ; Tue, 31 Mar 2009 13:22:03 +0000 (UTC) Received: from samaflost.de ([127.0.0.1]) by localhost (v30161.1blu.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 12002-04 for ; Tue, 31 Mar 2009 15:22:02 +0200 (CEST) Received: by samaflost.de (Postfix, from userid 2525) id A3C21E22000A; Tue, 31 Mar 2009 15:22:02 +0200 (CEST) To: dev@commons.apache.org Subject: Re: svn commit: r760390 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java X-Draft-From: ("nnfolder:mail.jakarta-lib" 124690) References: <20090331103556.08CD623889DE@eris.apache.org> <25aac9fc0903310515g67ef8a43v3a597742cd0f45a9@mail.gmail.com> From: Stefan Bodewig Date: Tue, 31 Mar 2009 15:22:02 +0200 In-Reply-To: <25aac9fc0903310515g67ef8a43v3a597742cd0f45a9@mail.gmail.com> (sebb's message of "Tue\, 31 Mar 2009 13\:15\:03 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: amavisd-new at samaflost.de X-Virus-Checked: Checked by ClamAV on apache.org On 2009-03-31, sebb wrote: > On 31/03/2009, Stefan Bodewig wrote: >> setSize is dangerous here since it may very well > 0 for directories >> on Unix like systems. > Oops! > However it should be OK for regular files, no? I hope so. I recall some problems with pretty old JDKs on exotic platforms that had been reported in ant land, but that's all long ago now, so I'd say it is safe. Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org