Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of jak-commons-dev@m.gmane.org
 designates 80.91.229.2 as permitted sender)
Mail-Followup-To: dev@commons.apache.org
To: dev@commons.apache.org
From: =?ISO-8859-1?Q?J=F6rg?= Schaible <joerg.schaible@gmx.de>
Subject: [configuration] Review please: svn commit: r755352 - in
 /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider:
 http/HttpFileObject.java webdav/WebdavFileObject.java
Date: Thu, 19 Mar 2009 23:06:43 +0100
Lines: 105
Message-ID: <gpuflj$mu4$2@ger.gmane.org>
References: <200903172038.05840.joerg.schaible@gmx.de>
Reply-To: joerg.schaible@gmx.de
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8Bit
Mail-Copies-To: never
User-Agent: KNode/0.10.9
Sender: news <news@ger.gmane.org>

Ralph, ping?

J�rg Schaible wrote:

> Guys,
> 
> I am not sure about my change here. It was simply not compilable in
> Eclipse, but that might also have been due to stricter compiler settings.
> Actually both HttpFileObject and WebdavFileObject contain a setupMethod
> method. In both classes it was declared package private, therefore it was
> not overridden. However, this might have been the desired effect. Probably
> the Webdav methods must be setup differently alone, while the standard
> methods inherited from the Http should not use this setup. In this case
> I'll revert this change. Ralph?
> 
> - J�rg
> 
> --------------- Weitergeleitete Nachricht (Anfang)
> 
> Betreff: svn commit: r755352 -
> in
> /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider:
> http/HttpFileObject.java webdav/WebdavFileObject.java Absender:
> joehni@apache.org Datum: Tue, 17 Mar 2009
> 20:01:19 +0100 Newsgruppe: gmane.comp.jakarta.commons.scm
> 
> Author: joehni
> Date: Tue Mar 17 19:01:18 2009
> New Revision: 755352
> 
> URL: http://svn.apache.org/viewvc?rev=755352&view=rev
> Log:
> setupMethod must be protected to be overridden.
> 
> Modified:
>     
>
commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/http/HttpFileObject.java
>     
>
commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/webdav/WebdavFileObject.java
> 
> Modified:
>
commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/http/HttpFileObject.java
> URL:
>
http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/http/HttpFileObject.java?rev=755352&r1=755351&r2=755352&view=diff
>
==============================================================================
> ---
>
commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/http/HttpFileObject.java
> (original)
> +++
>
commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/http/HttpFileObject.java
> Tue Mar 17 19:01:18 2009
> @@ -168,7 +168,7 @@
>      /**
>       * Prepares a Method object.
>       */
> -    void setupMethod(final HttpMethod method) throws FileSystemException,
> URIException
> +    protected void setupMethod(final HttpMethod method) throws
> FileSystemException, URIException
>      {
>          String pathEncoded = ((URLFileName)
> getName()).getPathQueryEncoded(urlCharset);
>          method.setPath(pathEncoded);
> 
> Modified:
>
commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/webdav/WebdavFileObject.java
> URL:
>
http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/webdav/WebdavFileObject.java?rev=755352&r1=755351&r2=755352&view=diff
>
==============================================================================
> ---
>
commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/webdav/WebdavFileObject.java
> (original)
> +++
>
commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/webdav/WebdavFileObject.java
> Tue Mar 17 19:01:18 2009
> @@ -319,7 +319,7 @@
>       * @throws FileSystemException if an error occurs encoding the uri.
>       * @throws URIException if the URI is in error.
>       */
> -    void setupMethod(final HttpMethod method) throws FileSystemException,
> URIException
> +    protected void setupMethod(final HttpMethod method) throws
> FileSystemException, URIException
>      {
>          String pathEncoded = ((URLFileName)
> getName()).getPathQueryEncoded(urlCharset);
>          method.setPath(pathEncoded);
> 
> 
> 
> 
> --------------- Weitergeleitete Nachricht (Ende)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org