Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 12727 invoked from network); 19 Mar 2009 06:07:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 Mar 2009 06:07:25 -0000 Received: (qmail 34545 invoked by uid 500); 19 Mar 2009 06:07:24 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 34262 invoked by uid 500); 19 Mar 2009 06:07:24 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 34251 invoked by uid 99); 19 Mar 2009 06:07:24 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Mar 2009 23:07:24 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of grobmeier@gmail.com designates 209.85.220.166 as permitted sender) Received: from [209.85.220.166] (HELO mail-fx0-f166.google.com) (209.85.220.166) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Mar 2009 06:07:16 +0000 Received: by fxm10 with SMTP id 10so319997fxm.42 for ; Wed, 18 Mar 2009 23:06:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=zavdQ0pkHA9uPAGEyT8fTKinRVOufDo338PFuh6a3zk=; b=gNhA+NPCAX1OkA9m/n59T1cv/EYGUUD/Zr0rfUm7LLAlMv+a7raO1XnL+8j0gzCYjy 6JHQ2nsPqMzFl9JBkJco5WFdShcRonk3WADYmhTHC5jOubVHD/eRh3evagaYZhoUdqn8 C4/6XFw6l3ukNz/BWl3GsS2kE2lwOZDmablwA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=nR68o+aOfVmi1zp2F+dwXJLy7071h+49rPwwxU2ulHOp+1MxOJXYe1j+g4ATwNMNjh ml+htBPxvY3xDrI+j6cLFDFISKcN+u5umFVCPtTQ/yEu7qnes5vpp0ekH2qcB7nfa+vI GpvUvAZ5uBY8r/3zznFYiMrlz6ws00JZzCd/k= MIME-Version: 1.0 Received: by 10.223.126.66 with SMTP id b2mr1773083fas.18.1237442815018; Wed, 18 Mar 2009 23:06:55 -0700 (PDT) In-Reply-To: <25aac9fc0903180322x2be20d19id5f4a480ff3e823a@mail.gmail.com> References: <25aac9fc0903180322x2be20d19id5f4a480ff3e823a@mail.gmail.com> Date: Thu, 19 Mar 2009 07:06:54 +0100 Message-ID: Subject: Re: [compress] Protected API From: Christian Grobmeier To: Commons Developers List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org I added a patch for CPIO to SANDBOX-294 Cheers On Wed, Mar 18, 2009 at 11:22 AM, sebb wrote: > On 18/03/2009, Stefan Bodewig wrote: >> On 2009-03-18, Stefan Bodewig wrote: >> >> =C2=A0> I'd like to remove some fields, make them private or final and m= aybe >> =C2=A0> move some methods around before our first release. =C2=A0In part= icular: >> >> >> I just saw sebb's patch attached to SANDBOX-294 and he seems to agree >> =C2=A0with most of my points. > > Yes - start with no non-private mutable variables (hopefully keep it > that way), and only make methods non-private if they are needed for > the API or the class hierarchy. > >> =C2=A0In addition the patch makes some package >> =C2=A0private fields bzip2 private - which I think is a a good idea as w= ell. >> >> >> =C2=A0Stefan >> >> =C2=A0------------------------------------------------------------------= --- >> =C2=A0To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >> =C2=A0For additional commands, e-mail: dev-help@commons.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org