Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of mario@ops.co.at designates
 195.242.168.21 as permitted sender)
From: Mario Ivankovits <mario@ops.co.at>
To: 'Commons Developers List' <dev@commons.apache.org>
Date: Thu, 26 Mar 2009 07:49:31 +0100
Subject: RE: [VFS] "anonymous" debug logging
Thread-Topic: [VFS] "anonymous" debug logging
Thread-Index: AcmtxqOpWOE7Av3VTDC34Br6BuHIqwAFxtZA
Message-ID: <FAD140A6C8872442B36609E3610939792CBBECC7@ex1>
References: 
 <94C476C03BFF5E42AC3518FDAC9643C4D044BD55A9@HQMAIL.rocketsoftware.com>
 <4F273B32-3CC8-405B-BEDB-AB004AFB2894@dslextreme.com>
In-Reply-To: <4F273B32-3CC8-405B-BEDB-AB004AFB2894@dslextreme.com>
Accept-Language: de-DE
Content-Language: de-DE
acceptlanguage: de-DE
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hi!


> From: Ralph Goers [mailto:ralph.goers@dslextreme.com]
>=20
> I'm not a big fan of that.

Me too, any decent logging facility should allow to configure the logger on=
 a "per package" level, so no problem to make the logging silent for a give=
n package.


> I'd prefer to switch to SLF4J and just replace

Everyone in commons land is using commons-logging, no?
There is no good reason to leave this path. Sure, for my work-projects I us=
e slf4j too, lately I even use the Java Logging API (which is worse), but a=
lways by using a the commons-logging API (not the Impl, just the API)

Everyone wanting to use slf4j can easily do that by using the slf4j-commons=
-logging adapter and removing the commons-logging jar. Not a big deal.
There is no benefit in switching to slf4j at all for commons-vfs, or?

>=20
> 		if (log.isDebugEnabled())
> 		{
> 			log.debug("putFile: " + file.getName());
> 		}
>=20
> with
>=20
> 		logger.entry(file.getName());


This is not the same, in the second example getName() gets evaluated every =
time, regardless of the configured log-level. Depending on how complicated =
it is to collect the message, this might become a performance problem. the =
if (log.isXXXEnabled()) prevents that.

I'd prefer to keep it the way it is.=20

Ciao,
Mario

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org