Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 64924 invoked from network); 19 Mar 2009 22:51:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 Mar 2009 22:51:06 -0000 Received: (qmail 13727 invoked by uid 500); 19 Mar 2009 22:51:05 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 13653 invoked by uid 500); 19 Mar 2009 22:51:05 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 13642 invoked by uid 99); 19 Mar 2009 22:51:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Mar 2009 15:51:05 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of ralph.goers@dslextreme.com designates 209.85.146.176 as permitted sender) Received: from [209.85.146.176] (HELO wa-out-1112.google.com) (209.85.146.176) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Mar 2009 22:50:57 +0000 Received: by wa-out-1112.google.com with SMTP id j32so419674waf.10 for ; Thu, 19 Mar 2009 15:50:36 -0700 (PDT) Received: by 10.114.190.18 with SMTP id n18mr1987762waf.101.1237503036702; Thu, 19 Mar 2009 15:50:36 -0700 (PDT) Received: from ?192.168.10.129? (adsl-66-51-196-164.dslextreme.com [66.51.196.164]) by mx.google.com with ESMTPS id n30sm1691313wag.21.2009.03.19.15.50.35 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 19 Mar 2009 15:50:36 -0700 (PDT) Message-Id: From: Ralph Goers To: "Commons Developers List" In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Apple Message framework v930.3) Subject: Re: [configuration] Review please: svn commit: r755352 - in /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider: http/HttpFileObject.java webdav/WebdavFileObject.java Date: Thu, 19 Mar 2009 15:50:34 -0700 References: <200903172038.05840.joerg.schaible@gmx.de> X-Mailer: Apple Mail (2.930.3) X-Virus-Checked: Checked by ClamAV on apache.org Sorry, I've had a busy couple of days. Basically, the webdav support =20 leverages the HTTP support where possible, but the setupMethod in the =20= WebdavFileObject does do a bit more. Frankly, I simply never tried =20 making the setup method in HttpFileObject protected so I don't know if =20= there would be any issues with the Http methods using the Webdav =20 setupMethod. I will give it a try and see what happens. Ralph On Mar 19, 2009, at 3:06 PM, J=F6rg Schaible wrote: > Ralph, ping? > > J=F6rg Schaible wrote: > >> Guys, >> >> I am not sure about my change here. It was simply not compilable in >> Eclipse, but that might also have been due to stricter compiler =20 >> settings. >> Actually both HttpFileObject and WebdavFileObject contain a =20 >> setupMethod >> method. In both classes it was declared package private, therefore =20= >> it was >> not overridden. However, this might have been the desired effect. =20 >> Probably >> the Webdav methods must be setup differently alone, while the =20 >> standard >> methods inherited from the Http should not use this setup. In this =20= >> case >> I'll revert this change. Ralph? >> >> - J=F6rg >> >> --------------- Weitergeleitete Nachricht (Anfang) >> >> Betreff: svn commit: r755352 - >> in >> /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/=20= >> provider: >> http/HttpFileObject.java webdav/WebdavFileObject.java Absender: >> joehni@apache.org Datum: Tue, 17 Mar 2009 >> 20:01:19 +0100 Newsgruppe: gmane.comp.jakarta.commons.scm >> >> Author: joehni >> Date: Tue Mar 17 19:01:18 2009 >> New Revision: 755352 >> >> URL: http://svn.apache.org/viewvc?rev=3D755352&view=3Drev >> Log: >> setupMethod must be protected to be overridden. >> >> Modified: >> >> > commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/=20 > provider/http/HttpFileObject.java >> >> > commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/=20 > provider/webdav/WebdavFileObject.java >> >> Modified: >> > commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/=20 > provider/http/HttpFileObject.java >> URL: >> > = http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/o= rg/apache/commons/vfs/provider/http/HttpFileObject.java?rev=3D755352&r1=3D= 755351&r2=3D755352&view=3Ddiff >> > =3D=20 > =3D=20 > =3D=20 > =3D=20 > =3D=20 > =3D=20 > =3D=20 > =3D=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- >> > commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/=20 > provider/http/HttpFileObject.java >> (original) >> +++ >> > commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/=20 > provider/http/HttpFileObject.java >> Tue Mar 17 19:01:18 2009 >> @@ -168,7 +168,7 @@ >> /** >> * Prepares a Method object. >> */ >> - void setupMethod(final HttpMethod method) throws =20 >> FileSystemException, >> URIException >> + protected void setupMethod(final HttpMethod method) throws >> FileSystemException, URIException >> { >> String pathEncoded =3D ((URLFileName) >> getName()).getPathQueryEncoded(urlCharset); >> method.setPath(pathEncoded); >> >> Modified: >> > commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/=20 > provider/webdav/WebdavFileObject.java >> URL: >> > = http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/o= rg/apache/commons/vfs/provider/webdav/WebdavFileObject.java?rev=3D755352&r= 1=3D755351&r2=3D755352&view=3Ddiff >> > =3D=20 > =3D=20 > =3D=20 > =3D=20 > =3D=20 > =3D=20 > =3D=20 > =3D=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- >> > commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/=20 > provider/webdav/WebdavFileObject.java >> (original) >> +++ >> > commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/=20 > provider/webdav/WebdavFileObject.java >> Tue Mar 17 19:01:18 2009 >> @@ -319,7 +319,7 @@ >> * @throws FileSystemException if an error occurs encoding the =20= >> uri. >> * @throws URIException if the URI is in error. >> */ >> - void setupMethod(final HttpMethod method) throws =20 >> FileSystemException, >> URIException >> + protected void setupMethod(final HttpMethod method) throws >> FileSystemException, URIException >> { >> String pathEncoded =3D ((URLFileName) >> getName()).getPathQueryEncoded(urlCharset); >> method.setPath(pathEncoded); >> >> >> >> >> --------------- Weitergeleitete Nachricht (Ende) > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org