Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of flamefew@gmail.com designates
 209.85.198.244 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=vIS2XpRMQWKQjtDkkoNuf6mSu73fj794P8erf9IXIexC48qLdXvad2D8i2gbkKtH0d
         oZJIiepbN9+uBDvLGQweYGVWAn1bmx7lDMEe8c6LedoXtiw6HDvycnKWfY2phU98eApf
         vTcplEUYncv6DR3QRdh659Ah5Za6np+9O69O0=
MIME-Version: 1.0
In-Reply-To: <25aac9fc0903180851n7c8c6875waeea71313ce6696d@mail.gmail.com>
References: <25aac9fc0903180851n7c8c6875waeea71313ce6696d@mail.gmail.com>
Date: Thu, 19 Mar 2009 22:38:07 -0700
Message-ID: <31cc37360903192238u13424739o96beedb5d83451cd@mail.gmail.com>
Subject: Re: [LANG] 3.0 JCIP Annotations
From: Henri Yandell <flamefew@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

+0 on the idea (tending to +1 with better understanding of the value).
I've not used jcip-annotations, but it seems like a good thing to
depend upon. Shared concerns with thread:

* Adding a dependency is wince-worthy, but I agree with you on it
being akin to JUnit and not runtime. We should have confidence in this
area and we can beat up on Maven if there are issues in the site.

* Java 7 - if these went in would it be painful in any way? Presumably
they wouldn't be in java.lang.*. Just raising the 'what would like
look like then?' flag.

Can you show what source, javadoc, site etc would look like for some
example classes?

On Wed, Mar 18, 2009 at 8:51 AM, sebb <sebbaz@gmail.com> wrote:
> I've added JCIP annotations jar to the POM, but not started adding any
> actual annotations yet.
>
> The idea would be to annotate every class as one of
>
> @Immutable
> @ThreadSafe
> @NotThreadSafe
>
> These annotation appear in the Javadoc output in the class description.
>
> Also, for objects that need synchronization to ensure thread safety,
> add the annotation
>
> @GuardedBy
>
> Are there any objections to proceeding with this?
>
> It's probably easiest to deal with @Immutable first, then @ThreadSafe.
>
> If no annotation is present, then the user _should_ assume that the
> class is @NotThreadSafe, but I think it would be better to always have
> an annotation so that it's clear it has not been accidentally left
> off.
>
> WDYT?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org