Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 41243 invoked from network); 17 Mar 2009 19:38:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Mar 2009 19:38:56 -0000 Received: (qmail 93754 invoked by uid 500); 17 Mar 2009 19:38:55 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 93682 invoked by uid 500); 17 Mar 2009 19:38:54 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 93671 invoked by uid 99); 17 Mar 2009 19:38:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Mar 2009 12:38:54 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of joerg.schaible@gmx.de designates 213.165.64.20 as permitted sender) Received: from [213.165.64.20] (HELO mail.gmx.net) (213.165.64.20) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 17 Mar 2009 19:38:45 +0000 Received: (qmail invoked by alias); 17 Mar 2009 19:38:24 -0000 Received: from HSI-KBW-078-042-174-106.hsi3.kabel-badenwuerttemberg.de (EHLO paddy.schaible.local) [78.42.174.106] by mail.gmx.net (mp068) with SMTP; 17 Mar 2009 20:38:24 +0100 X-Authenticated: #348333 X-Provags-ID: V01U2FsdGVkX19kvF4rz7Vk7Fe3nR8/nK4kRHfSBoj67Q6/NgAtnZ /nHKRYOaQdMLxA From: =?iso-8859-1?q?J=F6rg_Schaible?= Organization: N/A To: Commons Developers List Subject: Fwd: svn commit: r755352 - in /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider: http/HttpFileObject.java webdav/WebdavFileObject.java Date: Tue, 17 Mar 2009 20:38:03 +0100 User-Agent: KMail/1.9.9 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200903172038.05840.joerg.schaible@gmx.de> X-Y-GMX-Trusted: 0 X-FuHaFi: 0.48 X-Virus-Checked: Checked by ClamAV on apache.org Guys, I am not sure about my change here. It was simply not compilable in Eclipse= ,=20 but that might also have been due to stricter compiler settings. Actually=20 both HttpFileObject and WebdavFileObject contain a setupMethod method. In=20 both classes it was declared package private, therefore it was not=20 overridden. However, this might have been the desired effect. Probably the= =20 Webdav methods must be setup differently alone, while the standard methods= =20 inherited from the Http should not use this setup. In this case I'll revert= =20 this change. Ralph? =2D J=F6rg =2D-------------- Weitergeleitete Nachricht (Anfang) Betreff: svn commit: r755352 -=20 in /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/prov= ider:=20 http/HttpFileObject.java webdav/WebdavFileObject.java Absender: joehni-1oDqGaOF3Lkdnm+yROfE0A@public.gmane.org Datum: Tue, 17 Mar 2009 20:01:19 +0100 Newsgruppe: gmane.comp.jakarta.commons.scm Author: joehni Date: Tue Mar 17 19:01:18 2009 New Revision: 755352 URL: http://svn.apache.org/viewvc?rev=3D755352&view=3Drev Log: setupMethod must be protected to be overridden. Modified: =20 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider= /http/HttpFileObject.java =20 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider= /webdav/WebdavFileObject.java Modified:=20 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider= /http/HttpFileObject.java URL:=20 http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/or= g/apache/commons/vfs/provider/http/HttpFileObject.java?rev=3D755352&r1=3D75= 5351&r2=3D755352&view=3Ddiff =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D =2D--=20 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider= /http/HttpFileObject.java=20 (original) +++=20 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider= /http/HttpFileObject.java=20 Tue Mar 17 19:01:18 2009 @@ -168,7 +168,7 @@ /** * Prepares a Method object. */ =2D void setupMethod(final HttpMethod method) throws FileSystemException= ,=20 URIException + protected void setupMethod(final HttpMethod method) throws=20 =46ileSystemException, URIException { String pathEncoded =3D ((URLFileName)=20 getName()).getPathQueryEncoded(urlCharset); method.setPath(pathEncoded); Modified:=20 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider= /webdav/WebdavFileObject.java URL:=20 http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/or= g/apache/commons/vfs/provider/webdav/WebdavFileObject.java?rev=3D755352&r1= =3D755351&r2=3D755352&view=3Ddiff =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D =2D--=20 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider= /webdav/WebdavFileObject.java=20 (original) +++=20 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider= /webdav/WebdavFileObject.java=20 Tue Mar 17 19:01:18 2009 @@ -319,7 +319,7 @@ * @throws FileSystemException if an error occurs encoding the uri. * @throws URIException if the URI is in error. */ =2D void setupMethod(final HttpMethod method) throws FileSystemException= ,=20 URIException + protected void setupMethod(final HttpMethod method) throws=20 =46ileSystemException, URIException { String pathEncoded =3D ((URLFileName)=20 getName()).getPathQueryEncoded(urlCharset); method.setPath(pathEncoded); =2D-------------- Weitergeleitete Nachricht (Ende) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org