commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [compress] [PATCH] Refactoring of zip encoding support.
Date Wed, 04 Mar 2009 04:53:32 GMT
On 2009-03-03, Wolfgang Glas <wolfgang.glas@ev-i.at> wrote:

> Stefan Bodewig schrieb:
>> On 2009-03-03, Wolfgang Glas <wolfgang.glas@ev-i.at> wrote:

>>> Stefan Bodewig schrieb:
>>>> On 2009-03-02, Wolfgang Glas <wolfgang.glas@ev-i.at> wrote:

>>> Acccording to my tests WinZip recognizes the EFS flag upon
>>> reading.

>> Then my documenation is wrong 8-)

> Sorry for not exactly reading the Documentation,

No problem, will fix it.

>>> Secondly, if you set the encoding to UTF-8, there's no need for
>>> unicode extra fields anyway.

>> Except when your client doesnt recognize the EFS flag and thinks you'd
>> be using CP437 - but happily accepts the Unicode extra fields.  I
>> thought this would be the case for WinZIP.

> Yes, the EFS flag is of little usefulness. It has been added very
> late to Specs and most implementation ignore it right away.

IIUC it is detected by PKWARE, 7Zip and WinZIP, commons-compress - and
InfoZIP's unzip as well as Ant if the version is recent enough.  Not
too bad.

>> You vastly overestimate the effort it takes to write an Ant task.

> That nice, however, I hope that I can avoid adding ant to the list
> of OS-project I participate in ;-)

You already contributed to it, thanks.

>> createUnicodeExtraFields = NEVER (default) | ALWAYS | NOT_ENCODABLE
>> useLanguageEncodingFlag = true (default) | false
>> fallbackToUtf8 = true | false

> Agreed ;-)

> The implementation should be be straightforward, shall I prepare a
> patch or can you afford doing it at your own?

Will do it myself.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message