commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Grobmeier <grobme...@gmail.com>
Subject Re: [compress] Patch for SANDBOX-284
Date Wed, 18 Mar 2009 10:52:31 GMT
> Sorry, I still don't understand why refactoring would be needed in
> order for the code to be tested using CI?
>
> I must be missing something - can you explain?
> I'm curious to know what the problem is that requires refactoring for CI.

Sorry for beeing unclear. Refactoring is big term for "extracting a method".
Currently code is:

if( System.Property.OS == Windows)
   // do windows related path stuff
else
  // do *nix related path stuff
end if

The windows related stuff has roundabout 10 lines of code and can
never be reached in CI, since those are  running on unix. Means, that
aprt is never beeing tested.

If we would extract a method with the windows stuff, the method could
be tested (by reflection, cause it is private).

Hope this makes it more clear now :-)
Cheers

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message