commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Grobmeier <grobme...@gmail.com>
Subject [compress] PATCH: Fwd: [jira] Created: (SANDBOX-299) ArchiveStreamFactory.createArchiveInputStream() & createArchiveOutputStream() should throw Exception if archiverName is not recognised
Date Thu, 12 Mar 2009 06:56:25 GMT
Hi,
I added a patch to Jira.

The attached patch fixes the following:

    * ArchiveStreamFactory and CompressStreamFactory throw an
Exception now if no fitting Archiver/Compressor cand be found
    * If the name of the impl. or the stream is null, an
IllegalArgumentException will be thrown
    * ArchiverStreamFactory.createArchiveInputStream(final InputStream
in) doesn't throw in IOException anymore (will be wrapped around
ArchiveException, like Compressor-Factory does)
    * ArchiverStreamFactory.createArchiveInputStream(final InputStream
in) now checks if the incoming stream is true at markSupported(). If
no, an IllegalArgumentException will be thrown. I also removed the
TODO on that place.

Please apply, if you agree :-)
Cheers
Christian


---------- Forwarded message ----------
From: Sebb (JIRA) <jira@apache.org>
Date: Wed, Mar 4, 2009 at 8:23 PM
Subject: [jira] Created: (SANDBOX-299)
ArchiveStreamFactory.createArchiveInputStream() &
createArchiveOutputStream() should throw Exception if archiverName is
not recognised
To: issues@commons.apache.org


ArchiveStreamFactory.createArchiveInputStream() &
createArchiveOutputStream() should throw Exception if archiverName is
not recognised
--------------------------------------------------------------------------------------------------------------------------------------

                Key: SANDBOX-299
                URL: https://issues.apache.org/jira/browse/SANDBOX-299
            Project: Commons Sandbox
         Issue Type: Bug
         Components: Compress
           Reporter: Sebb
           Priority: Minor


ArchiveStreamFactory.createArchiveInputStream() should throw an
Exception if archiverName is not recognised - at present it returns
null, which is not particularly helpful.

The method sig says it throws ArchiveException; however it could also
throw IllegalArgumentException.

Likewise for createArchiveOutputStream()


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message