commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Grobmeier <grobme...@gmail.com>
Subject Re: [jira] Created: (SANDBOX-297) AbstractTestCase.createArchive method appears to use incorrect file size - cut and paste error?
Date Thu, 12 Mar 2009 06:37:12 GMT
Patch for this is now attached to Jira. If somebody has some time left.. :-)

Cheers,
Christian

On Wed, Mar 4, 2009 at 2:45 PM, Sebb (JIRA) <jira@apache.org> wrote:
> AbstractTestCase.createArchive method appears to use incorrect file size - cut and paste
error?
> -----------------------------------------------------------------------------------------------
>
>                 Key: SANDBOX-297
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-297
>             Project: Commons Sandbox
>          Issue Type: Bug
>          Components: Compress
>            Reporter: Sebb
>            Priority: Minor
>
>
> The createArchive() method has the following code:
> {code}
> ZipArchiveEntry entry = new ZipArchiveEntry("testdata/test1.xml");
> entry.setSize(file1.length());
> out.putArchiveEntry(entry);
> IOUtils.copy(new FileInputStream(file1), out);
> out.closeArchiveEntry();
>
> entry = new ZipArchiveEntry("testdata/test2.xml");
> entry.setSize(file1.length());     // <== should this be file2.length?
> out.putArchiveEntry(entry);
> IOUtils.copy(new FileInputStream(file2), out);
> out.closeArchiveEntry();
> {code}
>
> This looks a bit odd, as the setSize() parameter does not agree with the copy() parameter.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message