commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Wolfgang Glas <>
Subject Re: [compress] [PATCH] Refactoring of zip encoding support.
Date Mon, 02 Mar 2009 18:39:53 GMT
Stefan Bodewig schrieb:
> On 2009-03-01, Wolfgang Glas <> wrote:
>> 1) Unicode extra fields are written for all ZIP entries and not only
>> for entries, which are not encodable by the encoding set to
>> ZipArchiveOutputStream.
> Maybe room for yet another flag?  Or an enum-like option
> setCreateUnicodeExtraFields(NEVER | ALWAYS | NOT_ENCODABLE)

I like the idea of a unicode policy flag ;-)

My suggestion is

  SURROGATES   | /* no extra fields, no utf-8 fallback, only %Uxxxx surrogates*/
  EXTRA_FIELDS | /* extra fields for unencodable entriey, no utf-8 fallback   */
  EXTRA_FIELDS_ALWAYS | /* extra fields for all entries, no utf-8 fallback    */
  UTF8_FALLBACK| /* fall back to utf-8 plus EFS flag for unencodable entries. */
  UTF8_FALLBACK_EXTRA_FIELDS| /* fall back to utf-8 plus EFS flag plus extra
                                 fields for unencodable */
  UTF8_FALLBACK_EXTRA_FIELDS_ALWAYS /* fall back to utf-8 plus EFS flag for
                                       unencodable entries, exta fields for all
                                       entries. */

We might drop the last two options and we might choose a better wording, however
the direction should IMHO be as above mentioned...



To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message