commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Wolfgang Glas <wolfgang.g...@ev-i.at>
Subject Re: [compress] State of encoding support in ZIP package
Date Mon, 02 Mar 2009 15:36:51 GMT
Stefan Bodewig schrieb:
> On 2009-03-01, Wolfgang Glas <wolfgang.glas@ev-i.at> wrote:
> 
>> My understanding from previous discussion was, that we need a mode,
>> where file names not encodable by the chosen encoding are encoded in
>> UTF-8, which is in turn indicated by setting the EFS flag on the
>> likewise ZIP entry. (That's the way 7-zip handles unicode
>> filenames...)
> 
> This is different from what we've currently implemented, but may stiil
> be useful.
> 
>> The current implementation of the useEFS flag simply allocs to
>> disable the creation of the UFS flag in ZIP entries, which are
>> UTF-8. This approach is not conformant with the specifiations I've
>> read and I have not seen a single zip implementation, which is
>> disturbed by the EFS flag.
> 
> But if there should be one - say zlib on z/OS or some other strange
> thing, it will be good to have that option available,

OK, agreed, let's keep this flag ;-)

>> My opinion would be to simply drop the possibility to inhibit the
>> EFS flag in utf-8 encoded files and to introduce a new flag allowing
>> to switch to utf-8 fallbacks (7-zip mode...).
> 
> I'm fine with an additional flag that would encode not-encodable file
> names as UTF-8 (not sure about the name of the flag and I have a long
> standing history for chosing bad names), but prefer to keep the
> existing option for the completely orthogonal case of whether we set
> the EFS at all.

OK, I will introduce an additional flag, let's call it
'setFallbackToUtf8(boolean)'. I will prepare a patch right after you've review
and (possibly) committed my latest encoding refatoring patch.

  Best regards,

    Wolfgang


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message