commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r760390 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java
Date Tue, 31 Mar 2009 14:20:02 GMT
On 31/03/2009, Stefan Bodewig <bodewig@apache.org> wrote:
> On 2009-03-31, sebb <sebbaz@gmail.com> wrote:
>
>  > On 31/03/2009, Stefan Bodewig <bodewig@apache.org> wrote:
>
>
> >> setSize is dangerous here since it may very well > 0 for directories
>  >>  on Unix like systems.
>
>  > Oops!
>
>  > However it should be OK for regular files, no?
>
>
> I hope so.  I recall some problems with pretty old JDKs on exotic
>  platforms that had been reported in ant land, but that's all long ago
>  now, so I'd say it is safe.
>

For archive formats that only store the entry size in the header, then
output streams need to use and trust File#length() - unless one wants
to read the file twice.

>  Stefan
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message