commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r760000 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/ar/ArArchiveOutputStream.java test/java/org/apache/commons/compress/archivers/ArTestCase.java
Date Mon, 30 Mar 2009 16:59:48 GMT
On 30/03/2009, Stefan Bodewig <bodewig@apache.org> wrote:
> On 2009-03-30, sebb <sebbaz@gmail.com> wrote:
>
>  > Might it not be better to throw an Exception if methods are called out
>  > of sequence?
>
>
> We are pretty inconsistent here.  In general I agree it would be
>  better to throw an exception, but we seem to swallow other errors in
>  other classes.

In that case, why don't we fix the other classes?

If we document the required behaviour (e.g. in the abstract i/o
classes), then we can work towards making the code consistent.

>  Stefan
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message