commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [compress] potential bzip2 improvement
Date Thu, 26 Mar 2009 11:36:49 GMT
On 26/03/2009, Stefan Bodewig <bodewig@apache.org> wrote:
> Hi folks,
>
>  first of all I don't know enough about the bzip2 format to undestand
>  the existing code, nor the one I'll be pointing at further down.
>
>  The current code in compress is the one of Ant 1.7.1 and versions
>  prior to 1.7.0.  In Ant 1.7.0 Ant shipped with a completely rewritten
>  version that was a lot faster
>
>  https://issues.apache.org/bugzilla/show_bug.cgi?id=24798
>
>  Unfortunatly that version created corrupt archives under certain
>  circumstances
>
>  https://issues.apache.org/bugzilla/show_bug.cgi?id=41596
>
>  and the change was reverted in Ant 1.7.1.
>
>  The Hadoop folks have been using the version of Ant 1.7.0, ran into
>  the same corruption but had somebody around who actually understood
>  the code and fixed it.  So Ant's Bugzilla now contains a patch to
>  BZip2OutputStream that has the potential to be a lot faster, isn't
>  really any less understandable than the existing code (which is
>  impossible anyway) and is claimed to be tested by Hadoop.
>
>  Do we want to use Hadoop's code (provided it passes the existing unit
>  tests) for the 1.0 release or do we want to stick to the current code
>  and try an upgrade after the release?
>
>  Since I understand neither code base, I don't really have any
>  preference.

Would it be a silly idea to include both variants?

>  Stefan
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message