commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ralph Goers <ralph.go...@dslextreme.com>
Subject Re: [configuration] Review please: svn commit: r755352 - in /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider: http/HttpFileObject.java webdav/WebdavFileObject.java
Date Fri, 20 Mar 2009 05:34:41 GMT
I ran the test and this is fine.

Ralph

On Mar 19, 2009, at 3:50 PM, Ralph Goers wrote:

> Sorry, I've had a busy couple of days. Basically, the webdav support  
> leverages the HTTP support where possible, but the setupMethod in  
> the WebdavFileObject does do a bit more. Frankly, I simply never  
> tried making the setup method in HttpFileObject protected so I don't  
> know if there would be any issues with the Http methods using the  
> Webdav setupMethod.  I will give it a try and see what happens.
>
> Ralph
>
> On Mar 19, 2009, at 3:06 PM, Jörg Schaible wrote:
>
>> Ralph, ping?
>>
>> Jörg Schaible wrote:
>>
>>> Guys,
>>>
>>> I am not sure about my change here. It was simply not compilable in
>>> Eclipse, but that might also have been due to stricter compiler  
>>> settings.
>>> Actually both HttpFileObject and WebdavFileObject contain a  
>>> setupMethod
>>> method. In both classes it was declared package private, therefore  
>>> it was
>>> not overridden. However, this might have been the desired effect.  
>>> Probably
>>> the Webdav methods must be setup differently alone, while the  
>>> standard
>>> methods inherited from the Http should not use this setup. In this  
>>> case
>>> I'll revert this change. Ralph?
>>>
>>> - Jörg
>>>
>>> --------------- Weitergeleitete Nachricht (Anfang)
>>>
>>> Betreff: svn commit: r755352 -
>>> in
>>> /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/ 
>>> vfs/provider:
>>> http/HttpFileObject.java webdav/WebdavFileObject.java Absender:
>>> joehni@apache.org Datum: Tue, 17 Mar 2009
>>> 20:01:19 +0100 Newsgruppe: gmane.comp.jakarta.commons.scm
>>>
>>> Author: joehni
>>> Date: Tue Mar 17 19:01:18 2009
>>> New Revision: 755352
>>>
>>> URL: http://svn.apache.org/viewvc?rev=755352&view=rev
>>> Log:
>>> setupMethod must be protected to be overridden.
>>>
>>> Modified:
>>>
>>>
>> commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/ 
>> provider/http/HttpFileObject.java
>>>
>>>
>> commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/ 
>> provider/webdav/WebdavFileObject.java
>>>
>>> Modified:
>>>
>> commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/ 
>> provider/http/HttpFileObject.java
>>> URL:
>>>
>> http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/http/HttpFileObject.java?rev=755352&r1=755351&r2=755352&view=diff
>>>
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>>> ---
>>>
>> commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/ 
>> provider/http/HttpFileObject.java
>>> (original)
>>> +++
>>>
>> commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/ 
>> provider/http/HttpFileObject.java
>>> Tue Mar 17 19:01:18 2009
>>> @@ -168,7 +168,7 @@
>>>    /**
>>>     * Prepares a Method object.
>>>     */
>>> -    void setupMethod(final HttpMethod method) throws  
>>> FileSystemException,
>>> URIException
>>> +    protected void setupMethod(final HttpMethod method) throws
>>> FileSystemException, URIException
>>>    {
>>>        String pathEncoded = ((URLFileName)
>>> getName()).getPathQueryEncoded(urlCharset);
>>>        method.setPath(pathEncoded);
>>>
>>> Modified:
>>>
>> commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/ 
>> provider/webdav/WebdavFileObject.java
>>> URL:
>>>
>> http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/webdav/WebdavFileObject.java?rev=755352&r1=755351&r2=755352&view=diff
>>>
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>>> ---
>>>
>> commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/ 
>> provider/webdav/WebdavFileObject.java
>>> (original)
>>> +++
>>>
>> commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/ 
>> provider/webdav/WebdavFileObject.java
>>> Tue Mar 17 19:01:18 2009
>>> @@ -319,7 +319,7 @@
>>>     * @throws FileSystemException if an error occurs encoding the  
>>> uri.
>>>     * @throws URIException if the URI is in error.
>>>     */
>>> -    void setupMethod(final HttpMethod method) throws  
>>> FileSystemException,
>>> URIException
>>> +    protected void setupMethod(final HttpMethod method) throws
>>> FileSystemException, URIException
>>>    {
>>>        String pathEncoded = ((URLFileName)
>>> getName()).getPathQueryEncoded(urlCharset);
>>>        method.setPath(pathEncoded);
>>>
>>>
>>>
>>>
>>> --------------- Weitergeleitete Nachricht (Ende)
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message