commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Schaible <joerg.schai...@gmx.de>
Subject Re: [VOTE] Release Commons CLI 1.2 (RC6)
Date Sat, 14 Mar 2009 13:09:16 GMT
Hi Hen,

Henri Yandell wrote:

> On Thu, Mar 12, 2009 at 4:12 PM, Jörg Schaible <joerg.schaible@gmx.de>
> wrote:

[snip]

>> Therefore we may either ensure that a call to create will always reset
>> the builder in case of an IAE (CLI-177) or we can simply fix the tests
>> that use the builder by calling reset manually in the setUp (actually we
>> must create a simple option, since reset is private). Shall I commit
>> this?
> 
> I think fixing the tests and adding javadoc is best right now. We can
> evaluate CLI-177 after that, but I don't want to hold up a release and
> this is the kind of fix that would be nice to have sitting in trunk
> for a while being picked up by people before baking it in.
> 
> Let me know when you've done that and I'll spin another RC out.

Have a look at CLI-177, it's simply a call to OptionBuilder.reset in a finally 
block instead in the end of normal application flow and an explicit call 
before an IAE (and a unit tests). Therefore I'd tend to fix it properly here, 
simply because it's not really changing standard behavior, but prevents from 
random settings injection. Fixing the tests by invoking reset in setUp is 
more a hack, since the reset method is not public. I simply did not want to 
commit CLI-177 without agreement in the middle of an RC.

- Jörg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message