Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 30098 invoked from network); 16 Feb 2009 14:49:57 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 Feb 2009 14:49:57 -0000 Received: (qmail 15744 invoked by uid 500); 16 Feb 2009 14:49:56 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 15659 invoked by uid 500); 16 Feb 2009 14:49:56 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 15646 invoked by uid 99); 16 Feb 2009 14:49:56 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Feb 2009 06:49:56 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of grobmeier@gmail.com designates 209.85.220.16 as permitted sender) Received: from [209.85.220.16] (HELO mail-fx0-f16.google.com) (209.85.220.16) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Feb 2009 14:49:49 +0000 Received: by fxm9 with SMTP id 9so34642fxm.18 for ; Mon, 16 Feb 2009 06:49:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=KznqKD8ySZXrhiuDEbk82z5fNz2jlZ4JMPlyGt3eH7o=; b=vUcW4GYNds2Om3bqHZ26QNbi6BVXIPTMIM6sQmFJ1M/476leirJnofoxRyOODeLcmr ihqr2cOqEQt3wIo/ojQh72KIFi8y3d6ihvK3P9QPc9PghTJt+e6a7ticmiCJ51chqLXm /h+FXSXJvtpCbfZi0gKNF8WAMaPovBAH/F9X4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=P5o1P7pR/B5eVQtchmNneD4Xlvahob0RpfXxduehnWakxiuMsnOvl6UYq6bckFH+CL slcPwgqYwcONMcl1xnK9d6byvqzLEQDKLA0eZwE5lXVJsSXtbpN3GiXp3lbbyC6AtV2X M2+IfUpakgjlEyTiSUBYKLavd1eqhDk3xHFQY= MIME-Version: 1.0 Received: by 10.223.108.140 with SMTP id f12mr536312fap.23.1234795576983; Mon, 16 Feb 2009 06:46:16 -0800 (PST) In-Reply-To: References: Date: Mon, 16 Feb 2009 15:46:16 +0100 Message-ID: Subject: Re: [compress] patch for SANDBOX-183 From: Christian Grobmeier To: Commons Developers List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Hi, > Four of the tests fail if I apply the patch: > > Failed tests: > testDeleteDir(org.apache.commons.compress.changes.ChangeSetTestCase) > testDeletePlusAdd(org.apache.commons.compress.changes.ChangeSetTestCase) > testAddDeleteAdd(org.apache.commons.compress.changes.ChangeSetTestCase) > testDeleteAddDelete(org.apache.commons.compress.changes.ChangeSetTestCase) > > I've disabled those tests and changed AbstractTestCase to actually log > why it fails. In each of the four cases there is an enexpected entry > inside the archive: > > testDeleteDir unexpected entry: bla/test4.xml > testDeletePlusAdd unexpected entry: bla/test4.xml > testAddDeleteAdd unexpected entry: blub/test.txt > testDeleteAddDelete unexpected entry: bla/test.txt yes, I know that. The ChangeSet Implementation isn't finished currently. We (means: Torsten and myself) spoke at the list about the expected results, and I implemented them. Now I have to work on the ChangeSet itself to provide the expected results. > In a follow-up commit I fixed whitespace. Please set your editor to > not use any TABs at all. OK, will do. Sorry for that. Cheers + thanks for the commit, Christian --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org