Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of flamefew@gmail.com designates
 209.85.198.243 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=gknx/NDzeswg7cHf+xTWuTa5G7J26ioz2al7ugChmYVcHnHq8xd37CWPy1qrXYffj3
         uQNO3eHRJfnBFMOj7sv7Bz0KPpPRyaANKErNbzPl1gpWOcUWYhsHsVrH72lEU6qaO9oV
         /vetVU/Wn9izY/B/D0XXo2+EnjuT04SYIfnpk=
MIME-Version: 1.0
In-Reply-To: <gobpq6$e1a$1@ger.gmane.org>
References: <31cc37360902270150g4791251ay16845a4383123c44@mail.gmail.com>
	 <goa6sb$tcp$1@ger.gmane.org>
	 <31cc37360902271923x4b6d6833s46cc389908b59f72@mail.gmail.com>
	 <gobpq6$e1a$1@ger.gmane.org>
Date: Sat, 28 Feb 2009 12:15:12 -0800
Message-ID: <31cc37360902281215t5a27c79fy71582c78d82a7259@mail.gmail.com>
Subject: Re: [VOTE] Release of CLI 1.2 RC3
From: Henri Yandell <flamefew@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

I've fixed the first one - or should have (as I'm not setup to test).
Not a blocker on release though imo.

The second does not look like it'll have come about due to new code -
it was an attempt to increase code coverage so the bug is extremely
likely to already exist in 1.0, 1.1 etc. Not a blocker I think.

Hen

On Sat, Feb 28, 2009 at 8:47 AM, J=F6rg Schaible <joerg.schaible@gmx.de> wr=
ote:
> Hi Henry,
>
> Henri Yandell wrote:
>
>> Are these new errors J=F6rg, or do they happen with 1.1?
>
> Hardly, both tests did not exist yet in 1.1 ;-)
>
> OptionGroupTest.toString fails, because the option group is based on a
> HashMap which is printed in arbitrary order. Since the options are mutual=
ly
> exclusive, this is fine. I can commit an updated test at any time.
>
> However, HelpFormatterTest.printOptionGroup is different and gives me rea=
lly
> a headache. The test fails when I run it using Maven. In Eclipse (also wi=
th
> IBM JDK 1.6) it does not fail.
>
> Have a look at the test code:
>
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D %< =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =A0 =A0 =A0 =A0OptionGroup group =3D new OptionGroup();
> =A0 =A0 =A0 =A0group.addOption(OptionBuilder.create("a"));
> =A0 =A0 =A0 =A0group.addOption(OptionBuilder.create("b"));
> =A0 =A0 =A0 =A0group.addOption(OptionBuilder.create("c"));
>
> =A0 =A0 =A0 =A0Options options =3D new Options();
> =A0 =A0 =A0 =A0options.addOptionGroup(group);
>
> =A0 =A0 =A0 =A0StringWriter out =3D new StringWriter();
>
> =A0 =A0 =A0 =A0HelpFormatter formatter =3D new HelpFormatter();
> =A0 =A0 =A0 =A0formatter.printUsage(new PrintWriter(out), 80, "app", opti=
ons);
>
> =A0 =A0 =A0 =A0System.out.println(out.toString());
> =A0 =A0 =A0 =A0assertEquals("usage: app [-a | -b | -c]" + EOL, out.toStri=
ng());
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D %< =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>
> I have no idea, what causes the combo Maven/IBM JDK 6 to render a String
> of "usage: app [-a <arg>| -b | -c]" here. It simply does not make sence,
> but it is reproducible on every run.
>
> - J=F6rg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org