From dev-return-112448-apmail-commons-dev-archive=commons.apache.org@commons.apache.org Fri Feb 06 05:32:30 2009 Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 8023 invoked from network); 6 Feb 2009 05:32:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Feb 2009 05:32:30 -0000 Received: (qmail 56385 invoked by uid 500); 6 Feb 2009 05:32:29 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 56317 invoked by uid 500); 6 Feb 2009 05:32:29 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 56306 invoked by uid 99); 6 Feb 2009 05:32:29 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Feb 2009 21:32:29 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of grobmeier@gmail.com designates 72.14.220.155 as permitted sender) Received: from [72.14.220.155] (HELO fg-out-1718.google.com) (72.14.220.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Feb 2009 05:32:22 +0000 Received: by fg-out-1718.google.com with SMTP id 13so365791fge.24 for ; Thu, 05 Feb 2009 21:32:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=4bdVk0WjgP412481NPbtiBQinVgiBtXRzoWmaB8EYTA=; b=EM8A5c0frSMPilhHo6jPPn84qiqzcXrIAKYy1OXLHk0IakpG9m6o7h79SRLAd9QmeL YRPoHlJWpZ2BciEIMPHn0Srd3asQ9cH9fJgQCPy0CrdjQRWJNeLZfzApRKeXLaF58CFx MUqngukiGlaz1yHLPwSTxo41NtBHDIc/I2E88= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=qyk7LbwgP3YhCeuEBcNJEo0KXCRkgpC3HnlBp5LZrKEe0sYsdRKz1Flsc4+ku8Qe/Z KlQBxAO66O+qaKKR51pa1CATkzjriVwthIepjMcJTSv9Dq4HFlEJlRCjlZUgyLcJG0f+ lXm1oAVSBJhMMsowp1eVMkvUTJNwILfBbX4Gc= MIME-Version: 1.0 Received: by 10.86.59.18 with SMTP id h18mr740722fga.57.1233898321309; Thu, 05 Feb 2009 21:32:01 -0800 (PST) In-Reply-To: References: Date: Fri, 6 Feb 2009 06:32:01 +0100 Message-ID: Subject: Re: [compress] SANDBOX-246 remaining Findbugs issues From: Christian Grobmeier To: Commons Developers List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org > The svn merges were more or less painless, the only conflict I got was > in UnknownExtraField because the commons-compress version uses m_foo > fields where Ant uses foo (likely because of Avalon/Peter Donald > coding style). If you could do that - yes, thats cool then. > I suggest we add the number of bytes actually read as a second > argument to the various matches methods and will end up with no > InputStream matching the file's signature instead. OK Christian --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org