commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [compress] ZIP - encoding of file names - again
Date Thu, 19 Feb 2009 13:47:22 GMT
On 2009-02-18, Wolfgang Glas <wolfgang.glas@ev-i.at> wrote:

> Stefan Bodewig schrieb:

>> Wolfgang, you may notice a few minor tweaks to your original code.  Do
>> you happen to have stand-alone tests for the Unicode extra fields
>> anywhere?

> A rudimentary test is in my original patch as attached to SANDBOX-176.
> I have refactored this test to the current SVN revision an attached to this
> mail.

Thanks, I've modified it quite a bit, but its guts are still intact.
Committed.

> The test needs either be refactored to use ZipFile or
> ZipArchiveInputStream has to be implemented ;-)

ZipFile it is.

> I also had to expose the ZipEncodingHelper functionality to the
> public in order to compile the new test.

Just because you didn't add the test to the zip package 8-)

> You also need the two zip files attached to SANBOX-176 in
> src/test/resources in order to run the interoperability test.

They'll be added once EFS support is in.

I've added you as contributor to the POM, let me know if you want me
to remove the email address or use a different one.

Thanks!

        Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message