Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of jochen.wiedmann@gmail.com
 designates 72.14.220.153 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=k6fX8uo1BKzbavR6SubYweIydi3La0pfr3ayyrs9l66PJXchiL28kbrVZp1GwMuSBG
         blenniJ+VXHvArJ4BYoKscWgBkIPZmWpLgRoWuw6W3Ecx8O/aWft4KJFTRJuDxDF6D4e
         7+eASuBI4jaIDUcw2OXY/EbpmLZn5mrpmQA0k=
Message-ID: <e75283b10901180524s411b9f92v1141da96fefd348d@mail.gmail.com>
Date: Sun, 18 Jan 2009 14:24:55 +0100
From: "Jochen Wiedmann" <jochen.wiedmann@gmail.com>
To: "Commons Developers List" <dev@commons.apache.org>
Subject: Re: [fileupload] svn commit: r735370
In-Reply-To: <ce1f2ea80901171919s3909fa0bxf8a4a87baf93e08f@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <ce1f2ea80901171919s3909fa0bxf8a4a87baf93e08f@mail.gmail.com>

On Sun, Jan 18, 2009 at 4:19 AM, Rahul Akolkar <rahul.akolkar@gmail.com> wrote:

>> +        } finally {
>> +            if (!successful) {
>> +                for (Iterator iterator = items.iterator(); iterator.hasNext();) {
>> +                    FileItem fileItem = (FileItem) iterator.next();
>> +                    try {
>> +                        fileItem.delete();
>> +                    } catch (Throwable e) {
>> +                        // ignore it
>> +                    }
>
>
> Catch the bits that makes sense to ignore here?

Don't know, whether I understand your question right, Rahul. But if
the question is, whether ignoring the exception in the finally clause
is fine: Yes, it is! If the flag "successful" isn't set, then another
exception was thrown previously, and we want to see that exception,
not a follow-up.

Jochen

-- 
I have always wished for my computer to be as easy to use as my
telephone; my wish has come true because I can no longer figure out
how to use my telephone.

    -- (Bjarne Stroustrup,
http://www.research.att.com/~bs/bs_faq.html#really-say-that
       My guess: Nokia E50)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org