Return-Path: 
 <dev-return-112069-apmail-commons-dev-archive=commons.apache.org@commons.apache.org>
Delivered-To: apmail-commons-dev-archive@www.apache.org
Received: (qmail 88532 invoked from network); 8 Jan 2009 06:26:54 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 8 Jan 2009 06:26:54 -0000
Received: (qmail 26372 invoked by uid 500); 8 Jan 2009 06:26:53 -0000
Delivered-To: apmail-commons-dev-archive@commons.apache.org
Received: (qmail 26281 invoked by uid 500); 8 Jan 2009 06:26:53 -0000
Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@commons.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@commons.apache.org>
List-Post: <mailto:dev@commons.apache.org>
List-Id: <dev.commons.apache.org>
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Delivered-To: mailing list dev@commons.apache.org
Received: (qmail 26270 invoked by uid 99); 8 Jan 2009 06:26:53 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jan 2009 22:26:53 -0800
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of rahul.akolkar@gmail.com
 designates 209.85.219.13 as permitted sender)
Received: from [209.85.219.13] (HELO mail-ew0-f13.google.com) (209.85.219.13)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Jan 2009 06:26:46 +0000
Received: by ewy6 with SMTP id 6so9805455ewy.18
        for <dev@commons.apache.org>; Wed, 07 Jan 2009 22:26:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:message-id:date:from:to
         :subject:in-reply-to:mime-version:content-type
         :content-transfer-encoding:content-disposition:references;
        bh=1ZHfJqEs0Aupku5gwDswpQN1GfkMMUKekfUDcNST8qQ=;
        b=Bilr9y1X7f3Y7Rc8/BXdOyi60OP6nLWhDFtEaV8gr7nBxQYOpukhQDMn7+m/oX7nHl
         eG8FKAMCihhKLwixrp2JhRHHnO4wJpZ3Y4eAe7VbD3lkFOmleFJGmQ2Vq0AT5VxQKsiW
         9Uv+hl0RuABFEByH313dtBjeC0yv6Afxk/rVA=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=lMghI8NcKrMCO3QnQIb9EdNX/9lP1//XVgo2vqGP43syPr6xlXRrt9JYWIHJBLOcXI
         7fdHOSZn0LDGL85LaQDibUewg4tFCjuO2pFci1llvb1A8UIxMycgWQQ6CAvntVX/F9NA
         JFM4zO1HCT+d40g6uwjeUaFV+clRCIY4GiqUM=
Received: by 10.210.89.13 with SMTP id m13mr2377027ebb.166.1231395985118;
        Wed, 07 Jan 2009 22:26:25 -0800 (PST)
Received: by 10.210.53.9 with HTTP; Wed, 7 Jan 2009 22:26:25 -0800 (PST)
Message-ID: <ce1f2ea80901072226m7a67bb90q3969d448eb746f5f@mail.gmail.com>
Date: Thu, 8 Jan 2009 01:26:25 -0500
From: "Rahul Akolkar" <rahul.akolkar@gmail.com>
To: "Commons Developers List" <dev@commons.apache.org>
Subject: Re: [SCXML] J6 deprecations
In-Reply-To: <25aac9fc0901071221u21b2d660if8c735b49002876@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <25aac9fc0901071221u21b2d660if8c735b49002876@mail.gmail.com>
X-Virus-Checked: Checked by ClamAV on apache.org

On Wed, Jan 7, 2009 at 3:21 PM, sebb <sebbaz@gmail.com> wrote:
> Looks like the main remaining item with the J6 branch is the removal
> of deprecated code.
>
<snip/>

WRT the cleanup you mean? Perhaps. In general, that is by far not the
main remaining item. In terms of making the branch release-ready, the
main pending item is re-writing the parser so we can eliminate the
[digester] and therefore [beanutils] dependencies in this branch.
While its not trivial, the task shouldn't be too hard either given
cycles (perhaps using javax.xml.stream, others ideas welcome too). The
good thing is that this piece of work doesn't require an intricate
understanding of SCXML, since we merely need to populate the Commons
SCXML object model -- the oacs.model package -- with the fairly
obvious mappings from SCXML schema.

WRT action items, the BRANCHINFO file is kept fairly upto date. I made
some minor tweaks minutes ago:

  http://svn.apache.org/repos/asf/commons/proper/scxml/branches/J6/BRANCHINFO.txt


> In the case of SCXMLSemanticsImpl it looks like the two lines of code
> can just be removed as the comment says (the test still passes if I do
> this).
>
<snap/>

Yup.


> I'm not sure about the changes needed to SCXMLSerializer - can one
> just assume p = null at line 170?
> - i.e. remove the call to getParallel() and the first part of the if statement?
>
<snip/>

Yes (ofcourse running the tests will tell us if we have any old school
documents left behind).


> If so, then the deprecated methods getParallel() and isOrthogonal()
> can be removed from the State class.
>
> The remaining deprecations look a bit trickier.
>
> Transition.getTarget() is called by SCXMLSerializer.serializeTarget(),
> both of which are deprecated, but the latter is called by
> SCXMLSerializer.serializeTransition() which is not.
>
<snap/>

Both methods just need to be blown away, and the corresponding code in
serializeTransition() can be removed. Basically it means we used to
allow such markup before:

<transition ...>
    <target>
    ...
    </target>
</transition>

Now we don't.


> serializeTarget() is called during testing by
> testSerializeTransitionEscapeXML(SCXMLSerializerTest.java:325)
> however it does nothing as getTarget() returns null.
>
<snip/>

Yup, not important anymore.

-Rahul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org