Return-Path: 
 <dev-return-112064-apmail-commons-dev-archive=commons.apache.org@commons.apache.org>
Delivered-To: apmail-commons-dev-archive@www.apache.org
Received: (qmail 3598 invoked from network); 7 Jan 2009 20:02:15 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 7 Jan 2009 20:02:15 -0000
Received: (qmail 22954 invoked by uid 500); 7 Jan 2009 20:02:13 -0000
Delivered-To: apmail-commons-dev-archive@commons.apache.org
Received: (qmail 22871 invoked by uid 500); 7 Jan 2009 20:02:13 -0000
Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@commons.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@commons.apache.org>
List-Post: <mailto:dev@commons.apache.org>
List-Id: <dev.commons.apache.org>
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Delivered-To: mailing list dev@commons.apache.org
Received: (qmail 22859 invoked by uid 99); 7 Jan 2009 20:02:13 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jan 2009 12:02:13 -0800
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of rahul.akolkar@gmail.com
 designates 209.85.219.13 as permitted sender)
Received: from [209.85.219.13] (HELO mail-ew0-f13.google.com) (209.85.219.13)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jan 2009 20:02:07 +0000
Received: by ewy6 with SMTP id 6so9579329ewy.18
        for <dev@commons.apache.org>; Wed, 07 Jan 2009 12:01:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:message-id:date:from:to
         :subject:in-reply-to:mime-version:content-type
         :content-transfer-encoding:content-disposition:references;
        bh=X13lsCCO0D3ejhOIHR9IlSD9alahS2BzsyMWbI5dogo=;
        b=BaXRoSYi6LL+Pief9aJuoXkx8XH1BPh73yZtDlXzVJnPnvgG1b8ukH5e7E8mcMnnem
         oARhx4X4HWe9Zz+RzoQmCExBzcCOeHxneboviQLTJqnOFsO9iGm8y7SgkS+2e/SbPDlc
         How7JxcxmKJWQhGYz0BfuMK570J8BZJkzVCEM=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=NZbZPy4zk+wyxB8AAKN9wUhIiG1X2rOiCCv3qHroF12Gq09qMo8fY5dPMtfUrLFeK2
         UqqJwXpi7x+PKC1zPJLCb7dClPcK3g16mFBPIvknjSB8Vxgr9inqlVkdSbmsvpeviROl
         CDdC+FdiHG3FFXiG8sed2me05vTPSM2FxrQ7Q=
Received: by 10.210.91.17 with SMTP id o17mr27710760ebb.117.1231358504338;
        Wed, 07 Jan 2009 12:01:44 -0800 (PST)
Received: by 10.210.53.9 with HTTP; Wed, 7 Jan 2009 12:01:44 -0800 (PST)
Message-ID: <ce1f2ea80901071201t7dfa6c80xffc5912075e5cd66@mail.gmail.com>
Date: Wed, 7 Jan 2009 15:01:44 -0500
From: "Rahul Akolkar" <rahul.akolkar@gmail.com>
To: "Commons Developers List" <dev@commons.apache.org>
Subject: Re: [SCXML] J6 tidyup
In-Reply-To: <25aac9fc0901071145tb1eb71cre8d9a40d87a46ea9@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <25aac9fc0901070928l65d9287bp3e9e0cd760b03ff2@mail.gmail.com>
	 <ce1f2ea80901071051l9e6c835y2175f733505ebc0e@mail.gmail.com>
	 <25aac9fc0901071145tb1eb71cre8d9a40d87a46ea9@mail.gmail.com>
X-Virus-Checked: Checked by ClamAV on apache.org

On Wed, Jan 7, 2009 at 2:45 PM, sebb <sebbaz@gmail.com> wrote:
> On 07/01/2009, Rahul Akolkar <rahul.akolkar@gmail.com> wrote:
>> On Wed, Jan 7, 2009 at 12:28 PM, sebb <sebbaz@gmail.com> wrote:
>>  > Eclipse warns that there are unnecessary
>>  > @SuppressWarnings("unchecked") annotations in the SCXMLParser and
>>  > JSBindings classes - is it OK to remove them?
>>  >
>>
>> <snip/>
>>
>>  Yup, if you're convinced they aren't needed.
>
> OK, done.
>
>>
>>  > Also, there are some warnings about boxing/unboxing in
>>  > FunctionResolver and SCInstance - do you want to suppress the warnings
>>  > - or perform the boxing?
>>  >
>>  > [I've fixed the boxing warnings in the test code]
>>  >
>>
>> <snap/>
>>
>>  Perhaps the little code simplification is worth the purported
>>  performance issues? They should be handling booleans mostly (atleast
>>  in the source part). You can also turn off the warning in Eclipse if
>>  you want.
>
> I think the message is more about whether the boxing is intentional or
> not, rather than a performance issue. So fixing the warnings indicates
> that the boxing is OK.
>
<snip/>

Its intentional and OK, as you note below.

-Rahul


> In SCInstance setDone() and isDone() I think it's clear that the
> parameter and return type are intended to be boolean, whereas the Map
> needs Boolean, so the autoboxing is OK.
>
> Likewise for FunctionResolver.
>
> I've added SuppressWarnings for these.
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org