Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of rahul.akolkar@gmail.com
 designates 74.125.78.144 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:mime-version:content-type
         :content-transfer-encoding:content-disposition;
        b=rt55kp0XDrXNdhSriofDxoeBqJDUaLqYqD89pMk9s3cHWmae1/Pp5Pn7vAYAIhBFdv
         I1lM5SGyvV/KmdtrTRasABFZuogM1ikn8UjwfLUslOpA5hFdFf3I1ObTLVtz3wVyj35U
         JmsVV53JbO8vzXZcrkyyRQAH9xcmzMdgErU5k=
Message-ID: <ce1f2ea80901042000i2e75d3bdjfc7ba221d066473c@mail.gmail.com>
Date: Sun, 4 Jan 2009 23:00:53 -0500
From: "Rahul Akolkar" <rahul.akolkar@gmail.com>
To: dev@commons.apache.org
Subject: Re: [SCXML] svn commit: r731387
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Sun, Jan 4, 2009 at 6:36 PM,  <sebb@apache.org> wrote:
> Author: sebb
> Date: Sun Jan  4 15:36:29 2009
> New Revision: 731387
>
> URL: http://svn.apache.org/viewvc?rev=731387&view=rev
> Log:
> Remove try/catch blocks for Exceptions that are not expected in testing
>
> Modified:
>    commons/proper/scxml/branches/J6/src/test/java/org/apache/commons/scxml/SCXMLTestHelper.java
>
<snip/>

The two changes below to treat NSEs as test errors are probably OK,
given that most JDKs 1.6 and above seem to use a sensible DOM
implementation (and general XML support). The same doesn't hold for
this class in trunk, however.

-Rahul


>
> -    public static SCXML testModelSerializability(final SCXML scxml) {
> +    public static SCXML testModelSerializability(final SCXML scxml) throws Exception {
>         File fileDir = new File(SERIALIZATION_DIR);
>         if (!fileDir.exists() && !fileDir.mkdir()) {
>             System.err.println("SKIPPED SERIALIZATION: Failed directory creation");
> @@ -293,29 +259,18 @@
>         String filename = SERIALIZATION_FILE_PREFIX
>             + getSequenceNumber() + SERIALIZATION_FILE_SUFFIX;
>         SCXML roundtrip = null;
> -        try {
> -            ObjectOutputStream out =
> -                new ObjectOutputStream(new FileOutputStream(filename));
> -            out.writeObject(scxml);
> -            out.close();
> -            ObjectInputStream in =
> -                new ObjectInputStream(new FileInputStream(filename));
> -            roundtrip = (SCXML) in.readObject();
> -            in.close();
> -        } catch (NotSerializableException nse) {
> -            // <data> nodes failed serialization
> -            System.err.println("SERIALIZATION ERROR: The DOM implementation"
> -                + " in use is not serializable");
> -            return scxml;
> -        } catch(IOException ex) {
> -            throw new RuntimeException(ex);
> -        } catch(ClassNotFoundException ex) {
> -            throw new RuntimeException(ex);
> -        }
> +        ObjectOutputStream out =
> +            new ObjectOutputStream(new FileOutputStream(filename));
> +        out.writeObject(scxml);
> +        out.close();
> +        ObjectInputStream in =
> +            new ObjectInputStream(new FileInputStream(filename));
> +        roundtrip = (SCXML) in.readObject();
> +        in.close();
>         return roundtrip;
>     }
>
> -    public static SCXMLExecutor testExecutorSerializability(final SCXMLExecutor exec) {
> +    public static SCXMLExecutor testExecutorSerializability(final SCXMLExecutor exec) throws Exception {
>         File fileDir = new File(SERIALIZATION_DIR);
>         if (!fileDir.exists() && !fileDir.mkdir()) {
>             System.err.println("SKIPPED SERIALIZATION: Failed directory creation");
> @@ -324,26 +279,14 @@
>         String filename = SERIALIZATION_FILE_PREFIX
>             + getSequenceNumber() + SERIALIZATION_FILE_SUFFIX;
>         SCXMLExecutor roundtrip = null;
> -        try {
> -            ObjectOutputStream out =
> -                new ObjectOutputStream(new FileOutputStream(filename));
> -            out.writeObject(exec);
> -            out.close();
> -            ObjectInputStream in =
> -                new ObjectInputStream(new FileInputStream(filename));
> -            roundtrip = (SCXMLExecutor) in.readObject();
> -            in.close();
> -        } catch (NotSerializableException nse) {
> -            // <data> nodes failed serialization, test cases do not add
> -            // other non-serializable context data
> -            System.err.println("SERIALIZATION ERROR: The DOM implementation"
> -                + " in use is not serializable");
> -            return exec;
> -        } catch(IOException ex) {
> -            throw new RuntimeException(ex);
> -        } catch(ClassNotFoundException ex) {
> -            throw new RuntimeException(ex);
> -        }
> +        ObjectOutputStream out =
> +            new ObjectOutputStream(new FileOutputStream(filename));
> +        out.writeObject(exec);
> +        out.close();
> +        ObjectInputStream in =
> +            new ObjectInputStream(new FileInputStream(filename));
> +        roundtrip = (SCXMLExecutor) in.readObject();
> +        in.close();
>         return roundtrip;
>     }
>
> @@ -355,4 +298,3 @@
>     }
>
>  }
> -
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org