Return-Path: 
 <dev-return-112063-apmail-commons-dev-archive=commons.apache.org@commons.apache.org>
Delivered-To: apmail-commons-dev-archive@www.apache.org
Received: (qmail 98318 invoked from network); 7 Jan 2009 19:45:46 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 7 Jan 2009 19:45:46 -0000
Received: (qmail 13926 invoked by uid 500); 7 Jan 2009 19:45:46 -0000
Delivered-To: apmail-commons-dev-archive@commons.apache.org
Received: (qmail 13415 invoked by uid 500); 7 Jan 2009 19:45:45 -0000
Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@commons.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@commons.apache.org>
List-Post: <mailto:dev@commons.apache.org>
List-Id: <dev.commons.apache.org>
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Delivered-To: mailing list dev@commons.apache.org
Received: (qmail 13403 invoked by uid 99); 7 Jan 2009 19:45:45 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jan 2009 11:45:45 -0800
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates
 72.14.220.157 as permitted sender)
Received: from [72.14.220.157] (HELO fg-out-1718.google.com) (72.14.220.157)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jan 2009 19:45:38 +0000
Received: by fg-out-1718.google.com with SMTP id 13so1403570fge.24
        for <dev@commons.apache.org>; Wed, 07 Jan 2009 11:45:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:message-id:date:from:to
         :subject:in-reply-to:mime-version:content-type
         :content-transfer-encoding:content-disposition:references;
        bh=X1GFi3HkJdp1saisQjzvkHwAeoIWKj1vjVG7wj9slJU=;
        b=fkJ8wiNYuiKeuJU2k4nrOE/hAguh8LCCZSOfSREmc2jB7Heh+rS6cHiSQNHXWPTl4t
         iUhZEWKuVaSK4TCggPLpzESF2cYWgNG3qdtPzIHTADpYjGusDGJm61yecoCz4xrkAEqm
         D7my9/6Mg0mVho+tpt95ujmcYVwfSEPqtXVnI=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=kg2cvwQl/BOZKNVVzVGbk78hQuWozmSgH8NXgRYIicHvTQSzZtJnqBGB4ik5JKUZ/5
         Hru319fRyAbsyRckCroaAeaXcdytCjtVk4xtsWjRBrImJ1Dii/fYtZZ3cFB8WAmcZz7I
         vsC4RvVxZRfDKRXg2u0DGSB0SDTwbrNlwt9YM=
Received: by 10.86.93.17 with SMTP id q17mr4439898fgb.50.1231357517181;
        Wed, 07 Jan 2009 11:45:17 -0800 (PST)
Received: by 10.86.51.7 with HTTP; Wed, 7 Jan 2009 11:45:17 -0800 (PST)
Message-ID: <25aac9fc0901071145tb1eb71cre8d9a40d87a46ea9@mail.gmail.com>
Date: Wed, 7 Jan 2009 19:45:17 +0000
From: sebb <sebbaz@gmail.com>
To: "Commons Developers List" <dev@commons.apache.org>
Subject: Re: [SCXML] J6 tidyup
In-Reply-To: <ce1f2ea80901071051l9e6c835y2175f733505ebc0e@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <25aac9fc0901070928l65d9287bp3e9e0cd760b03ff2@mail.gmail.com>
	 <ce1f2ea80901071051l9e6c835y2175f733505ebc0e@mail.gmail.com>
X-Virus-Checked: Checked by ClamAV on apache.org

On 07/01/2009, Rahul Akolkar <rahul.akolkar@gmail.com> wrote:
> On Wed, Jan 7, 2009 at 12:28 PM, sebb <sebbaz@gmail.com> wrote:
>  > Eclipse warns that there are unnecessary
>  > @SuppressWarnings("unchecked") annotations in the SCXMLParser and
>  > JSBindings classes - is it OK to remove them?
>  >
>
> <snip/>
>
>  Yup, if you're convinced they aren't needed.

OK, done.

>
>  > Also, there are some warnings about boxing/unboxing in
>  > FunctionResolver and SCInstance - do you want to suppress the warnings
>  > - or perform the boxing?
>  >
>  > [I've fixed the boxing warnings in the test code]
>  >
>
> <snap/>
>
>  Perhaps the little code simplification is worth the purported
>  performance issues? They should be handling booleans mostly (atleast
>  in the source part). You can also turn off the warning in Eclipse if
>  you want.

I think the message is more about whether the boxing is intentional or
not, rather than a performance issue. So fixing the warnings indicates
that the boxing is OK.

In SCInstance setDone() and isDone() I think it's clear that the
parameter and return type are intended to be boolean, whereas the Map
needs Boolean, so the autoboxing is OK.

Likewise for FunctionResolver.

I've added SuppressWarnings for these.

>  -Rahul
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org