commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rahul Akolkar" <rahul.akol...@gmail.com>
Subject Re: [SCXML] J6 tidyup
Date Wed, 07 Jan 2009 18:51:54 GMT
On Wed, Jan 7, 2009 at 12:28 PM, sebb <sebbaz@gmail.com> wrote:
> Eclipse warns that there are unnecessary
> @SuppressWarnings("unchecked") annotations in the SCXMLParser and
> JSBindings classes - is it OK to remove them?
>
<snip/>

Yup, if you're convinced they aren't needed.


> Also, there are some warnings about boxing/unboxing in
> FunctionResolver and SCInstance - do you want to suppress the warnings
> - or perform the boxing?
>
> [I've fixed the boxing warnings in the test code]
>
<snap/>

Perhaps the little code simplification is worth the purported
performance issues? They should be handling booleans mostly (atleast
in the source part). You can also turn off the warning in Eclipse if
you want.

-Rahul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message