commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bernhard Gr├╝newaldt <bernh...@gruenewaldt.net>
Subject Re: [math] Complex nth roots
Date Fri, 02 Jan 2009 10:13:26 GMT
+1 sounds good :)


Phil Steitz schrieb:
> Thanks, Bernhard for the contribution in MATH-236.  I would like to
> suggest a couple of improvements.
> 
> First, I think the return type should be List, not Collection, as there
> is an order to the elements in the returned collection (as stated in the
> API doc, the order is by increasing argument).

+1 (I have no objections on that)

> Second,  since we are also making the method that returns the argument
> public, I would prefer to name that "getArgument" (preferred) or
> "getArg" instead of "getPhi".

+1 (I have no objections on that)

> Finally,  in the loop that generates the roots, it would be better to
> compute the pie slice once and then add it each time instead of
> computing k* 2 * Math.PI/ n for each k > 1.

+1 (I have no objections on that)

> 
> If there are no objections, I will make these changes.
> 
> Thanks again for the contribution.
> 
> Phil
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message