commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [DBCP] svn commit: r734473
Date Thu, 15 Jan 2009 11:22:03 GMT
On 15/01/2009, Mark Thomas <markt@apache.org> wrote:
> > From: Phil Steitz [mailto:phil.steitz@gmail.com]
>
> >
>  > Stephen Colebourne wrote:
>  > > Rahul Akolkar wrote:
>  > >>
>
> > >> Note that the above breaks binary and source compatibility.
>  > Therefore,
>  > >> at the least, such changes deserve notable mentions in the release
>  > >> notes and often additional thought about the version number of the
>  > >> next release.
>  > >
>
> > > We shouldn't create any more jar hell situations.

As far as I can tell, making these static fields final will only break
code that tries to write to the field(s).

If code merely references the field, then it will continue to compile
and run against a final-ised version of the class.

Any code that writes to the fields in question is dubious at best, so
I personally don't see any problem in breaking it.

Surely "jar hell" can only happen to incorrect code in this case?

Or am I missing some subtlety here?

>  > I agree with Stephen on this.  This is a needless break.  I would
>  > prefer
>  > to limit changes to what is required to support compilation under JDK
>  > 1.6.   Otherwise, we need to target a 2.0 (and consider changing
>  > package
>  > name) and as there does not appear to be collective energy to push out
>  > a
>  > 1.2.3 bugfix release, I would really like to see 1.3 usable by current
>  > users as there are some nasty bugs that have been fixed in trunk.
>
>
> +1
>
>
>  Mark
>
>
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message