commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [SCXML] Deprecations in J6 branch (was: svn commit: r730816)
Date Sat, 03 Jan 2009 10:54:08 GMT
On 03/01/2009, Rahul Akolkar <rahul.akolkar@gmail.com> wrote:
> On Fri, Jan 2, 2009 at 11:10 PM, Rahul Akolkar <rahul.akolkar@gmail.com> wrote:
>  > On Fri, Jan 2, 2009 at 6:31 PM, sebb <sebbaz@gmail.com> wrote:
>  >> On 02/01/2009, Rahul Akolkar <rahul.akolkar@gmail.com> wrote:
>  >>> On Fri, Jan 2, 2009 at 2:03 PM,  <sebb@apache.org> wrote:
>  >>>  > Author: sebb
>  >>>  > Date: Fri Jan  2 11:03:42 2009
>  >>>  > New Revision: 730816
>  >>>  >
>  >>>  > URL: http://svn.apache.org/viewvc?rev=730816&view=rev
>  >>>  > Log:
>  >>>  > Add missing @Deprecated annotations
>  >>>  >
>  >>>  <snip/>
>  >>>
>  >>>  Which reminds me -- these deprecated fields and methods can simply
>  >>>  disappear from the J6 branch. The branch will result in a major
>  >>>  release whenever that happens since it has higher JDK requirements as
>  >>>  compared to trunk (amongst other reasons).
>  >>>
>  >>>  Some of the methods may be used elsewhere and if so, require a bit of
>  >>>  thought but the constants should be easy to remove if you'd like.
>  >>>
>  >>
>  >> OK, I've removed all the unused deprecated methods and fields.
>  >>
>  > <snip/>
>  >
>  > Thanks for that. Though I'm now getting 75 failures and 4 errors (mvn
>  > test). Will take a look now to see whats going on.

Oops - sorry, I forgot to re-test ...

>  >
>
> <snip/>
>
>  Fixed. Many of the test documents were using old-school attribute
>  names that broke the tests when the corresponding deprecated methods
>  were removed. While these didn't show up as compile-time references to
>  the methods, the parser uses reflection (via digester and beanutils)

Maybe methods which are known to be invoked by reflection should be
documented as such?

>  to populate some of the Commons SCXML object model which was no longer
>  correctly populated. I updated the test documents to use the new
>  attribute names.

So it all worked out OK in the end ;-)

>  Again, thanks for the cleanup of some of the tests and deprecated code.
>

OK.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message