commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brent Worden" <brent.wor...@gmail.com>
Subject Re: svn commit: r699157 - in /commons/proper/math/trunk/src: java/org/apache/commons/math/distribution/FDistributionImpl.java site/xdoc/changes.xml test/org/apache/commons/math/distribution/FDistributionTest.java
Date Fri, 26 Sep 2008 19:37:07 GMT
That plus some subsequent changes to FDistributionTest and credit to
Joerg in changes.xml for finding the issue.

On Fri, Sep 26, 2008 at 1:40 PM, Luc Maisonobe <Luc.Maisonobe@free.fr> wrote:
> brentworden@apache.org a écrit :
>> Author: brentworden
>> Date: Thu Sep 25 20:09:53 2008
>> New Revision: 699157
>>
>> URL: http://svn.apache.org/viewvc?rev=699157&view=rev
>> Log:
>> MATH-227.  fixed F distribution inverse CDF computation for small denominator degrees
of freedom.
>
> I would like to propagate this change to the 2.0 branch where most work
> happens now. However I don't want to apply it directly using svn
> commands because lots of noise has been added by some space characters
> being replaced with tab characters everywhere in this commit.
>
> I tracked the modification to the following change. Could you confirm
> the only thing related to bug fix is the replacement of:
>
>    protected double getInitialDomain(double p) {
>        return getDenominatorDegreesOfFreedom() /
>            (getDenominatorDegreesOfFreedom() - 2.0);
>    }
>
> by:
>
>    protected double getInitialDomain(double p) {
>        double ret = 1.0;
>        double d = getDenominatorDegreesOfFreedom();
>        if (d > 2.0) {
>            // use mean
>            ret = d / (d - 2.0);
>        }
>        return ret;
>    }
>
> thanks,
> Luc
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message