commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Schaible <Joerg.Schai...@scalaris.com>
Subject RE: [LANG] - suggestions for new Identity Hash code classes
Date Tue, 16 Sep 2008 12:59:49 GMT
sebb wrote:
> On 16/09/2008, Simon Kitching <skitching@apache.org> wrote:
[snip]
>>  One other concern is regarding garbage collection. From a brief
>> look at the code, this thread-local registry object contains a set
>> of Integer hashcodes. With this change, the set will now contain
>> real hard references to objects, preventing them from being
>> garbage-collected while they are in the set. Does this matter?
> 
> The entries are only retained in the registry during the hashcode
> calculation - if any were left behind they could mess up subsequent
> calls in the same thread. 
> 
> As far as I can see, the code always removes any items that are added,
> but it would be worth double-checking that.

In that case forget my other comment ;-)

- Jörg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message