commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Bubna" <nbu...@gmail.com>
Subject COLLECTIONS-271 fix breaks ExtendedProperties.getKeys()
Date Mon, 08 Sep 2008 16:27:15 GMT
Just in case this gets ignored in JIRA, i thought i'd post a friendly
nag here as well:

I think your patch for ExtendedProperties breaks getKeys() after a
combine() call. It appears to make combine() not track new keys, which
breaks both getKeys() and subset(). Because combine() then subset() is
broken, Velocity has been experiencing frustratingly mysterious
failures for months now. For more on the symptoms, see:

http://tinyurl.com/5hjxrq

I suspect instead of super.put(), the patch for this should have used
clearProperty() followed by addPropertyDirect(). Of course, i haven't
tested that...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message