commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [net] 2.0 Release Ready For Review
Date Mon, 22 Sep 2008 14:52:17 GMT
On 22/09/2008, Oberhuber, Martin <Martin.Oberhuber@windriver.com> wrote:
> > Also, the binary jar contains an examples/ directory, but it contains
>  > only the class files.
>  >
>  > Surely it should contain the source files instead?
>
>
> I'm not sure about best practices used in Apache Commons, but
>  it seems odd to me that examples code is even found in the
>  binary jar.

I suppose the idea is that it shows you how to use the code - which of
course requires the source, not the class files.

I think some binary jars also have the Javadoc.

>  Shouldn't the binary jar be ready for deployment into client
>  applications? Doesn't seem like source code or an examples/
>  package is right in something to be deployed.

If example source and Javadoc are included that only increases the jar
size - perhaps not ideal.

But having example classes is potentially a problem, especially if
they aren't in the expected package.

>  I'd rather put the examples into a separate Jar of their own,
>  but again I'm not sure what other Commons projects do?
>

That would be better - and/or on the web-site.

They should be in the source jar as well.

>  Cheers,
>  --
>  Martin Oberhuber, Senior Member of Technical Staff, Wind River
>  Target Management Project Lead, DSDP PMC Member
>  http://www.eclipse.org/dsdp/tm
>
>
>
>  > -----Original Message-----
>
> > From: sebb [mailto:sebbaz@gmail.com]
>  > Sent: Thursday, September 18, 2008 4:05 PM
>  > To: Commons Developers List
>  > Subject: Re: [net] 2.0 Release Ready For Review
>  >
>  > Also, the binary jar contains an examples/ directory, but it contains
>  > only the class files.
>  >
>  > Surely it should contain the source files instead?
>
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message