Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of jak-commons-dev@m.gmane.org
 designates 80.91.229.2 as permitted sender)
Mail-Followup-To: dev@commons.apache.org
To: dev@commons.apache.org
From: =?ISO-8859-1?Q?J=F6rg?= Schaible <joerg.schaible@gmx.de>
Subject: Re: [VOTE] Release JXPath 1.3 based on RC4
Date: Sat, 05 Jul 2008 15:00:57 +0200
Lines: 119
Message-ID: <g4nra9$l63$2@ger.gmane.org>
References: <907645.39486.qm@web55106.mail.re4.yahoo.com>
 <g4nr2s$l63$1@ger.gmane.org>
Reply-To: joerg.schaible@gmx.de
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart15586580.Qaz7omHuYZ"
Content-Transfer-Encoding: 7Bit
Mail-Copies-To: never
User-Agent: KNode/0.10.9
Sender: news <news@ger.gmane.org>

--nextPart15586580.Qaz7omHuYZ
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8Bit

Forgot to add the path for the POM, just in case you will do another RC.

J�rg Schaible wrote:

> Hi Matt,
> 
> Builds from source and works fine on my compiler zoo except for all
> IBM-JDKs, but that's a different story
> (http://jira.codehaus.org/browse/MNG-3580).
> 
> Some minor issues though in the docs:
> 
> - download page goes nowhere, I suspect this is caused by the current
> location and automatically fixed for the release
> - the links to the older APIs does not work, again I suspect this is fixed
> for the release
> - the user's guide contains a table of content at its top. However, quite
> all of the link anchors do not work
> 
> Issue in the POM:
> 
> - it defines a property "commons.release.version" with value 1.2. This is
> used by the download-page-template.xml to generate the download page in
> xdocs. Therefore currently all liks are generated for JXPath 1.2. Maybe
> the property's value in the POM should be defined as ${project.version} in
> general and its definition can move up to the parent-pom.
> - it declares an optional provided dep to commons-logging, which is simply
> not true, since jxpath does not make usage of commons-logging. However
> commons-beanutils has it as transitive dep in an old version, therefore
> commons-logging should be declared in a dependencyManagement with version
> 1.1.1 to overwrite the old transitive version
> - it declares an optional runtime dep to commons-collection, but it is not
> used by any other dependency and can therefore removed completely (all
> tests run fine without it)
> - I don't under stand why deps are declared with scope provided *and*
> optional. IMHO provided is enough, but it may have also effect on the
> generated dependencies page
> 
> Wiki:
> 
> - talks about release plan for 1.2 ;-)
> 
> 
> Summary:
> -1, simply because of the wrong download links, anything else is not
> critical
> 
> - J�rg


--nextPart15586580.Qaz7omHuYZ
Content-Type: text/x-diff; name="pom.patch"
Content-Transfer-Encoding: 8Bit
Content-Disposition: attachment; filename="pom.patch"

Index: pom.xml
===================================================================
--- pom.xml	(Revision 674189)
+++ pom.xml	(Arbeitskopie)
@@ -62,7 +62,7 @@
 
   <properties>
     <commons.componentid>jxpath</commons.componentid>
-    <commons.release.version>1.2</commons.release.version>
+    <commons.release.version>{project.version}</commons.release.version>
     <commons.binary.suffix />
     <commons.jira.id>JXPATH</commons.jira.id>
     <commons.jira.pid>12310480</commons.jira.pid>
@@ -100,18 +100,21 @@
       </plugin>
     </plugins>
   </build>
+  <dependencyManagement>
+    <dependencies>
+      <dependency>
+        <groupId>commons-logging</groupId>
+        <artifactId>commons-logging</artifactId>
+        <version>1.1.1</version>
+      </dependency>
+    </dependencies>
+  </dependencyManagement>
   <dependencies>
     <dependency>
-      <groupId>commons-logging</groupId>
-      <artifactId>commons-logging</artifactId>
-      <version>1.1.1</version>
-      <optional>true</optional>
-      <scope>runtime</scope>
-    </dependency>
-    <dependency>
       <groupId>xerces</groupId>
       <artifactId>xercesImpl</artifactId>
       <version>2.4.0</version>
+      <scope>provided</scope>
       <optional>true</optional>
     </dependency>
     <dependency>
@@ -154,13 +157,6 @@
       <optional>true</optional>
     </dependency>
     <dependency>
-      <groupId>commons-collections</groupId>
-      <artifactId>commons-collections</artifactId>
-      <version>3.2</version>
-      <optional>true</optional>
-      <scope>runtime</scope>
-    </dependency>
-    <dependency>
       <groupId>com.mockrunner</groupId>
       <artifactId>mockrunner-jdk1.3-j2ee1.3</artifactId>
       <version>0.4</version>


--nextPart15586580.Qaz7omHuYZ
Content-Type: text/plain; charset=us-ascii

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
--nextPart15586580.Qaz7omHuYZ--