Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 4167 invoked from network); 10 Jul 2008 21:38:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 Jul 2008 21:38:42 -0000 Received: (qmail 63197 invoked by uid 500); 10 Jul 2008 21:38:41 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 63123 invoked by uid 500); 10 Jul 2008 21:38:41 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 63112 invoked by uid 99); 10 Jul 2008 21:38:41 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Jul 2008 14:38:41 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [208.75.86.161] (HELO vafer.org) (208.75.86.161) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Jul 2008 21:37:48 +0000 Received: from dslb-084-058-058-040.pools.arcor-ip.net ([84.58.58.40]:33154 helo=[10.0.1.3]) by vafer.org with esmtpsa (TLS-1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.67) (envelope-from ) id 1KH3q4-0007FW-K4 for dev@commons.apache.org; Thu, 10 Jul 2008 21:38:09 +0000 Message-Id: <2BDEBF61-A062-4C10-B301-623B21990F73@apache.org> From: Torsten Curdt To: "Commons Developers List" In-Reply-To: <25aac9fc0807100629p9a4e726g63b63bdcdb5b09b6@mail.gmail.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v926) Subject: Re: [Compress] redesign SVN and AL fixups Date: Thu, 10 Jul 2008 23:38:04 +0200 References: <25aac9fc0807100336n1be5e68fyb1d75a443ddaf2d8@mail.gmail.com> <25aac9fc0807100629p9a4e726g63b63bdcdb5b09b6@mail.gmail.com> X-Mailer: Apple Mail (2.926) X-Virus-Checked: Checked by ClamAV on apache.org Of course fine with our ...but what about code that has pulled in from other apache projects? Credits into the notice file and then remove them? cheers -- Torsten On Jul 10, 2008, at 15:29, sebb wrote: > Also forgot to mention that there are some @author tags in the code > > IMO these should be removed: > > Per http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_09_22.txt > > "Recommend strongly that @author is avoided; but leave it to each PMC > to make the final call with their respective communities" > > S/// > On 10/07/2008, Torsten Curdt wrote: >> I suggest we fix this in svn first and then you can start from a >> clean >> git-svn clone if you want. >> >> cheers >> -- >> Torsten >> >> >> On Jul 10, 2008, at 12:46, Christian Grobmeier wrote: >> >> >>> thanks for that hint. >>> >>> @Torsten: can I fix that in my GIT branch without disturbing the >>> git-svn >>> commit? >>> Or should I wait till the commit has been finished? >>> >>> >>> On Thu, Jul 10, 2008 at 12:36 PM, sebb wrote: >>> >>> >>>> Just had a quick look at the compress redesign branch. >>>> >>>> There are some problems with the SVN settings: >>>> >>>> svn ps svn:eol-style native >>>> >>>> >> src/main/java/org/apache/commons/compress/archivers/tar/ >> TarArchiveOutputStream.java >>>> svn ps svn:eol-style native >>>> >> src/main/java/org/apache/commons/compress/archivers/zip/ZipEntry.java >>>> >>>> Possibly also these: >>>> svn ps svn:eol-style native src/main/resources/test1.xml >>>> svn ps svn:eol-style native src/main/resources/test2.xml >>>> svn ps svn:eol-style native src/test/resources/test1.xml >>>> svn ps svn:eol-style native src/test/resources/test2.xml >>>> >>>> Several java and XML files don't have AL headers: >>>> >>>> pom.xml >>>> >> src/main/java/org/apache/commons/compress/changes/Change.java >>>> >> src/main/java/org/apache/commons/compress/changes/DeleteChange.java >>>> >>>> >> src/main/java/org/apache/commons/compress/compressors/ >> CompressorException.java >>>> >>>> >> src/main/java/org/apache/commons/compress/compressors/ >> CompressorStreamFactory.java >>>> src/main/resources/test1.xml >>>> src/main/resources/test2.xml >>>> src/site/site.xml >>>> src/site/xdoc/index.xml >>>> >>>> >> src/test/java/org/apache/commons/compress/archivers/memory/ >> MemoryArchiveTestCase.java >>>> >> src/test/java/org/apache/commons/compress/changes/ >> ChangeWorkerTest.java >>>> >>>> Some files have merge conflict markers in them, e.g.: >>>> >>>> <<<<<<< HEAD:testdata/test.xml >>>> >>>> >> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: >> dev-unsubscribe@commons.apache.org >>>> For additional commands, e-mail: dev-help@commons.apache.org >>>> >>>> >>>> >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >> For additional commands, e-mail: dev-help@commons.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org