Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 14183 invoked from network); 18 Jun 2008 16:16:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 Jun 2008 16:16:35 -0000 Received: (qmail 60708 invoked by uid 500); 18 Jun 2008 16:16:36 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 60393 invoked by uid 500); 18 Jun 2008 16:16:35 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 60382 invoked by uid 99); 18 Jun 2008 16:16:35 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jun 2008 09:16:35 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of juliusdavies@gmail.com designates 209.85.132.242 as permitted sender) Received: from [209.85.132.242] (HELO an-out-0708.google.com) (209.85.132.242) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jun 2008 16:15:43 +0000 Received: by an-out-0708.google.com with SMTP id d18so78779and.72 for ; Wed, 18 Jun 2008 09:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=2evz0VnpMuWJvJpeBeW98JuwG9xE9JrbtUTVCF9kLRI=; b=nnme1vE+HZA38fuFuib9qhfeqr0BPrjwTy7AsmKAyY5tNQ6JJ8rSG8INrQMnttZeDF 3jEBIp0/ASKh6qKH8zRYNxJYOlEXWDZncfkhOflajlV4bL2xbfVsJfiT6qE94DkUgQvE 9ntOZbui4aB29zFdLpG1tf/t6skaveMOxSVYw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=m5hR5i/XN4REljkkdZF0opF/cHcg0YrOpgytPbnA5NjvlB2aarg3GS5SFN5uJd5IH2 h4JlFVlcpoI3Q4xokE4PwXCjWfZOzUmPM5SLBrry/wJJ3I6PoDdRHp+s/vv7artMn1+N SgFAcbz0Ms8tWQi+q9dzn+Qq00Go2RuOrWJ/c= Received: by 10.100.128.20 with SMTP id a20mr1295026and.153.1213805761451; Wed, 18 Jun 2008 09:16:01 -0700 (PDT) Received: by 10.100.105.19 with HTTP; Wed, 18 Jun 2008 09:16:01 -0700 (PDT) Message-ID: <598ad5b50806180916u2a34cab1u7dc61c0490da9d5@mail.gmail.com> Date: Wed, 18 Jun 2008 09:16:01 -0700 From: "Julius Davies" To: "Commons Developers List" Subject: Re: [codec] Base64InputStream In-Reply-To: <598ad5b50806160844m6eb5188eyf00f3c928332f98d@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <598ad5b50806100002g2ee9ac4chc8b571df10054b25@mail.gmail.com> <25aac9fc0806100330v78de4f63x116d990fbacc0965@mail.gmail.com> <598ad5b50806160844m6eb5188eyf00f3c928332f98d@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org Hi, I decided to create a new ticket (CODEC-69) rather than attach to CODEC-8. The scope of CODEC-8 is somewhat broader (streaming for all encoders/decoders in commons-codec!), and I don't think I have enough time to take it that far. The patch attached to CODEC-69 has JUnits added for many streaming variations, and javadocs on all non-test code. I hope people find it useful and worth committing! yours, Julius On Mon, Jun 16, 2008 at 8:44 AM, Julius Davies wrote: > Hi, > > Base64InputStream and Base64OutputStream are coming along. They both > have JUnit tests now: > > Source: > http://juliusdavies.ca/codec/src/java/org/apache/commons/codec/binary/ > > JUnit: > http://juliusdavies.ca/codec/src/test/org/apache/commons/codec/binary/ > > > I still need to do some more javadocs before I attach a patch to the > JIRA ticket. Right now the JUnits test byte-by-byte operation of the > streams (e.g. int i = in.read()), so I'd like to also introduce > chunk-by-chunk JUnit tests as well. > > > This was a fun test! (Wrap the InputStream over and over and over > again with decoding then encoding then decoding...). > > InputStream in = new ByteArrayInputStream(data); > in = new Base64InputStream(in, true); > in = new Base64InputStream(in, false); > in = new Base64InputStream(in, true); > in = new Base64InputStream(in, false); > in = new Base64InputStream(in, true); > in = new Base64InputStream(in, false); > in = new Base64InputStream(in, true); > in = new Base64InputStream(in, false); > in = new Base64InputStream(in, true); > in = new Base64InputStream(in, false); > in = new Base64InputStream(in, true); > in = new Base64InputStream(in, false); > in = new Base64InputStream(in, true); > in = new Base64InputStream(in, false); > in = new Base64InputStream(in, true); > in = new Base64InputStream(in, false); > > > > > > > yours, > > Julius > > -- yours, Julius Davies 250-592-2284 (Home) 250-893-4579 (Mobile) http://juliusdavies.ca/ --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org