Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 59128 invoked from network); 18 Jun 2008 10:36:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 Jun 2008 10:36:05 -0000 Received: (qmail 34674 invoked by uid 500); 18 Jun 2008 10:36:06 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 34591 invoked by uid 500); 18 Jun 2008 10:36:05 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 34580 invoked by uid 99); 18 Jun 2008 10:36:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jun 2008 03:36:05 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [212.27.42.30] (HELO smtp4-g19.free.fr) (212.27.42.30) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jun 2008 10:35:15 +0000 Received: from smtp4-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp4-g19.free.fr (Postfix) with ESMTP id 190953EA0BD for ; Wed, 18 Jun 2008 12:35:33 +0200 (CEST) Received: from [192.168.1.101] (did75-15-88-160-185-18.fbx.proxad.net [88.160.185.18]) by smtp4-g19.free.fr (Postfix) with ESMTP id E91053EA0F0 for ; Wed, 18 Jun 2008 12:35:32 +0200 (CEST) Message-ID: <4858E4F4.80902@apache.org> Date: Wed, 18 Jun 2008 12:35:32 +0200 From: Emmanuel Bourg User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: Commons Developers List Subject: Re: [compress] A few comments References: <48577DC1.5000104@apache.org> <4858060F.5030207@apache.org> <4858C83B.3030006@apache.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org Christian Grobmeier a écrit : > I agree with Torsten. There may occur other exceptions than plain > input/output errors. I looked at the code, indeed the exceptions in the refactored compress are always related to configuration issue, whereas in the current svn code errors are often created on IO issues (path not writable, file is not a directory, etc). Btw, regading this code in ArchiveStreamFactory : if (clazz == null) { throw new ArchiveException("ArchiverFactory could not create instance"); } Shouldn't this throw a NullPointerException instead ? Emmanuel Bourg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org