commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julius Davies" <juliusdav...@gmail.com>
Subject Re: [codec] Base64InputStream
Date Tue, 10 Jun 2008 16:33:27 GMT
Hi, Sebb,

Thanks for the review!  I'll switch to int in the final patch.

On Tue, Jun 10, 2008 at 3:30 AM, sebb <sebbaz@gmail.com> wrote:
> Just curious - why use a byte for the chunk size?
> I would have thought an int would be more usual (possibly accompanied
> by a range check).
> Likewise modulus - using an int would avoid a few casts.
>
> Or maybe these are from the original code.

-- 
yours,

Julius Davies
250-592-2284 (Home)
250-893-4579 (Mobile)
http://juliusdavies.ca/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message