commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Bourg <ebo...@apache.org>
Subject Re: [compress] A few comments
Date Wed, 18 Jun 2008 10:35:32 GMT
Christian Grobmeier a écrit :

> I agree with Torsten. There may occur other exceptions than plain
> input/output errors.

I looked at the code, indeed the exceptions in the refactored compress 
are always related to configuration issue, whereas in the current svn 
code errors are often created on IO issues (path not writable, file is 
not a directory, etc).

Btw, regading this code in ArchiveStreamFactory :

     if (clazz == null) {
         throw new ArchiveException("ArchiverFactory could not create 
instance");
     }

Shouldn't this throw a NullPointerException instead ?

Emmanuel Bourg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message