commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Release JXPath 1.3 based on RC3
Date Sat, 14 Jun 2008 19:36:43 GMT
On 14/06/2008, Matt Benson <gudnabrsam@yahoo.com> wrote:
>
>  --- Oliver Heger <oliver.heger@oliver-heger.de> wrote:
>
>  > +1
>  >
>  > Artifacts look very good. I also ran the tests for
>  > commons configuration
>  > with the new version successfully.
>  >
>  > The only thing that makes me a bit uneasy is the
>  > findbugs report showing
>  > 133 errors. Did you have a look at those?
>  >
>
>
> I actually didn't, but I don't see anything in there
>  that really surprises me.  Some false positives (e.g.
>  String ==), some Serialization issues I knew were
>  there.  It would be nice to attack these for another
>  release.

Certainly some of them need fixing, e.g.

Use of non-localized String.toUpperCase() or String.toLowerCase
at
http://people.apache.org/~mbenson/jxpath-1.3-rc3/site/xref/org/apache/commons/jxpath/ri/model/NodePointer.html#549
and
http://people.apache.org/~mbenson/jxpath-1.3-rc3/site/xref/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.html#330

These should use something like toUpperCase(Locale.ENGLISH).

Might also be worth adding exclusions for the bugs that are false positives...

>  Does your +1 still stand?
>
>
>  -Matt
>
>
>  > Oliver
>  >
>  > Matt Benson schrieb:
>  > > Thanks to anyone who reported issues with the
>  > previous
>  > > two release candidates, and especially to those
>  > who
>  > > helped resolve them.
>  > >
>  > > The artifacts are here:
>  > > http://people.apache.org/~mbenson/jxpath-1.3-rc3/
>  > >
>  > > The tag is here:
>  > >
>  >
>  http://svn.apache.org/viewvc/commons/proper/jxpath/tags/JXPATH_1_3_RC3/
>  > >
>  > > Site:
>  > >
>  >
>  http://people.apache.org/~mbenson/jxpath-1.3-rc3/site
>  > >
>  > > Clirr Report (compared to 1.2; one-shot not
>  > working w/
>  > > M2)
>  > >
>  >
>  http://people.apache.org/~mbenson/jxpath-1.3-rc3/clirr-report.txt
>  > >
>  > > I'd be grateful if you can make time to check the
>  > > artifacts and cast your vote, which will be open
>  > at
>  > > least until Friday, June 20.
>  > >
>  > > Thanks,
>  > > Matt
>  > >
>  > >
>  > >
>  > >
>  > >
>  >
>  ---------------------------------------------------------------------
>  > > To unsubscribe, e-mail:
>  > dev-unsubscribe@commons.apache.org
>  > > For additional commands, e-mail:
>  > dev-help@commons.apache.org
>  > >
>  >
>  >
>  >
>  ---------------------------------------------------------------------
>  > To unsubscribe, e-mail:
>  > dev-unsubscribe@commons.apache.org
>  > For additional commands, e-mail:
>  > dev-help@commons.apache.org
>  >
>  >
>
>
>
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message