Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 63653 invoked from network); 23 May 2008 02:22:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 23 May 2008 02:22:22 -0000 Received: (qmail 19181 invoked by uid 500); 23 May 2008 02:22:23 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 19097 invoked by uid 500); 23 May 2008 02:22:22 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 19086 invoked by uid 99); 23 May 2008 02:22:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 May 2008 19:22:22 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of niall.pemberton@gmail.com designates 209.85.146.181 as permitted sender) Received: from [209.85.146.181] (HELO wa-out-1112.google.com) (209.85.146.181) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 May 2008 02:21:36 +0000 Received: by wa-out-1112.google.com with SMTP id m34so523128wag.10 for ; Thu, 22 May 2008 19:21:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=R0cyp2xoCRtRHfybrVnKaePuqo74RCBa6A+4jC3pBkY=; b=nc5Be1rrkrysewdi82PoNcGIejSFSt62Lb2QnNGoTV7NV0ohcRVa3dPfBtCRY0PKPRKdeOI+GNn5AJUtdLoGO3Q6OvDPys5yA2BNRxJ6P7jfFk+Gg/l7jpFPmHmNWRrkFQQDelEc5c5cCKFf+AISqjJLvp/kPVRPmpz+U5dpMgI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=NRqKASK/rLUu9WmLNW6ART6VXgFfux9tAvJuPEpzu4N7SOSJ2NteUHArZLR2imkSjIklf61weJdiZo+XV7+mXt2hMDRC95V/SGDz1t21QZTGkMBBDJgWIQQ4cjjIOjNIzW9MsbyRFJu+WU54KCa7G8GO34WsW4QCrVOgJrDojLw= Received: by 10.114.200.2 with SMTP id x2mr1141887waf.19.1211509311748; Thu, 22 May 2008 19:21:51 -0700 (PDT) Received: by 10.114.56.1 with HTTP; Thu, 22 May 2008 19:21:51 -0700 (PDT) Message-ID: <55afdc850805221921j75a12885g37b4d4af490a92f2@mail.gmail.com> Date: Fri, 23 May 2008 03:21:51 +0100 From: "Niall Pemberton" To: "Commons Developers List" Subject: Re: [VOTE] Release Commons Chain 1.2 based on RC2 In-Reply-To: <4835E8EB.4010803@apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <55afdc850805211947s3aa397d3pc7c082b60c7a3171@mail.gmail.com> <4835E8EB.4010803@apache.org> X-Virus-Checked: Checked by ClamAV on apache.org On Thu, May 22, 2008 at 10:43 PM, Emmanuel Bourg wrote: > I'm a bit concerned by the low test coverage (64% lines and 55% branches > according to Cobertura). Some classes like CommandListener and ChainListener > aren't tested at all. The faces package isn't tested but its classes seem > more trivial. We don't have a CommandListener - but for ChainListener there is a working example webapp, which I added a while ago to be able to test the changes for CHAIN-35 (ticket for example webapp is CHAIN-36) http://svn.apache.org/viewvc/commons/proper/chain/tags/CHAIN_1_2_RC2/apps/example/ You're right though the unit test coverage could/should be improved. This is only a minor bugfix release though and I have (from memory) tested all the changes I made. Niall > Emmanuel Bourg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org