Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates
 74.125.46.153 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=PBehmyka1LuC2BPNDkO50++Aby4ZPznerkDkpP+3E4fqCkyVrl25q/LH1DP1N1U1BnMATFb5wlQ8MwUUXowlgbFmWRzxW8u+RTOb5ONQCsisELGfn4qb6aWCjuDhO2ATGWE8o1PBeR+L4dcxrQizl2LqHgskumEJ9xJK/Y4igLw=
Message-ID: <25aac9fc0805190829p38c47f28gf1c5609a4836ca3c@mail.gmail.com>
Date: Mon, 19 May 2008 16:29:11 +0100
From: sebb <sebbaz@gmail.com>
To: "Commons Developers List" <dev@commons.apache.org>
Subject: Re: Commons Net 1.5 / 2.0 Releases
In-Reply-To: <8833dc800805190718p64a84db7g41b5961dca2ea034@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: 
 <460801A4097E3D4CA04CC64EE648584805B5157A@ism-mail03.corp.ad.wrs.com>
	 <482F5555.6090109@eircom.net>
	 <8833dc800805190718p64a84db7g41b5961dca2ea034@mail.gmail.com>

On 19/05/2008, Niklas Gustavsson <niklas@protocol7.com> wrote:
> On Sat, May 17, 2008 at 11:59 PM, Rory Winston <rory.winston@gmail.com> wrote:
>  > Are we ready to cut another RC? I can do so if you guys are happy with where
>  > we're at.
>
>
> I still got this issue:
>  https://issues.apache.org/jira/browse/NET-217
>
>  I haven't look into any depth at why it's happening, but changing the
>  test to using unique ports for each of the tests (6900, 6901, 6902...)
>  make JUnit all happy. Should I commit this fix? With it, I would be
>  happy to see 2.0 released.

I think I saw the same error, but only once, so I assumed it was
something else happening on my system.

If it's occurring regularly, then there may be a problem with
releasing the port from previous tests in the same class.

However, I have just seen a problem in the TFTPServer code - the
constructors call launch() which creates a new thread and starts it.
This is not thread-safe, as the class is not guaranteed to be fully
constructed until after the constructor has completed. There are some
other thread-safety problems too; I'll raise a JIRA.

I don't know if it relates to the test failure or not - I suppose the
unsafe constructor could mean that shutdown does not happen reliably.

>
>
>  /niklas
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org