commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rahul Akolkar" <rahul.akol...@gmail.com>
Subject Re: [all] Commons SCXML 0.8 RC1 available
Date Sun, 11 May 2008 02:01:12 GMT
Thanks for your time sebb, comments below ...

On Sat, May 10, 2008 at 9:00 AM, Niall Pemberton
<niall.pemberton@gmail.com> wrote:
> On Sat, May 10, 2008 at 1:03 PM, sebb <sebbaz@gmail.com> wrote:
>> On 10/05/2008, Rahul Akolkar <rahul.akolkar@gmail.com> wrote:
<snip/>
>>>
>>>  I plan on cutting RC2 mid next week. In the mean time, if anyone has
>>>  other comments about RC1, please post here.
>>>
>>
>> Looks good.
>>
>> Some very minor nits:
>>
>> * It would be nice if the source and javadoc manifests had a bit more
>> detail in them, for example adding the following from the binary
>> manifest:
<snap/>

Yup, I agree the manifests can be better. I don't have much time for
this during the Commons SCXML v0.8 release. As Niall says, I'll try to
look for a Commons-wide solution if I have any cycles for this down
the road.


>
> For any of our m2 releases, this is only going to happen when someone
> provides a solution - probably by sumitting a patch to the
> sources/javadocs plugins:
>
> http://maven.apache.org/plugins/maven-source-plugin/
> http://maven.apache.org/plugins/maven-javadoc-plugin/
>
> Niall
>
>> Implementation-Title: Commons SCXML
>> Implementation-Vendor: The Apache Software Foundation
>> Implementation-Vendor-Id: org.apache
>> Implementation-Version: 0.8
>> Specification-Title: Commons SCXML
>> Specification-Vendor: The Apache Software Foundation
>> Specification-Version: 0.8
>>
>> * There's no need for the .asc.sha1 and .asc.md5 digests.
>>
<snip/>

Indeed, there isn't: http://markmail.org/message/w7behn7tacpr2lca


>> * Building with M1 gives:
>> DEPRECATED: the default goal should be specified in the <build>
>> section of project.xml instead of maven.xml
>> ...
>> java:jar:
>>    [echo] java:jar is deprecated and will be removed. Please use jar:jar
>>
<snap/>

Using m1.0.2? Thats the recommended version in Commons (see building
page in site, for example).


>> * Perhaps the M1 build should be deleted?
>>
<snip/>

Not immediately. I still use it and it works well.


>> * The tests generate rather a lot of INFO output.
>>
<snap/>

I'm not bothered by that (but if more people think it should be
reduced, I can do that). Additionally, since I need to cut RC2 with
JDK 1.5, I want to make zero changes to Java sources/tests between RC1
and RC2 (RC1 was built with JDK 1.4, so we'd trivially know the
sources are OK for a 1.4 target).

-Rahul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message