commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz" <phil.ste...@gmail.com>
Subject Re: [VOTE] Release Commons Chain 1.2 based on RC2
Date Mon, 26 May 2008 04:07:54 GMT
That would be -1, on the bits in the RC.  I will change to +1 if we
can get the site build working on Unix or bundle the docs with the
binary release.  It looks like the necessary fix has been applied to
fix the site build in trunk, so all that is needed is to roll a final
RC.

Phil

On Sat, May 24, 2008 at 9:39 PM, Paul Benedict <pbenedict@apache.org> wrote:
> Phil, was there a vote attached to your suggestion?
>
> On Sat, May 24, 2008 at 10:45 PM, Phil Steitz <phil.steitz@gmail.com> wrote:
>
>> On Thu, May 22, 2008 at 7:10 PM, Niall Pemberton
>> <niall.pemberton@gmail.com> wrote:
>> > On Thu, May 22, 2008 at 9:35 PM, Luc Maisonobe <Luc.Maisonobe@free.fr>
>> wrote:
>> >> A few comments on this release.
>> >>
>> >> Typo in the project description in the pom.xml file: replace
>> >> "implmentation" with "implementation".
>> >>
>> >> Extracting files from the commons-chain-1.2-src.tar.gz archive in a
>> >> Linux box leads to an all lower case file name for "license-header.txt",
>> >> which leads to an error when running "mvn site". Some plugin requires a
>> >> mixed case LICENSE-header.txt.
>> >
>> > Thanks, I fixed the typo and checkstyle config in the trunk:
>> >  http://svn.apache.org/viewvc?view=rev&revision=659361
>> >
>> > Anyone think we need a new RC for this?
>> >
>>
>> Sorry, but yes I think this should be fixed, since neither the m1 nor
>> m2 site builds work (on Linux at least) and neither the source nor the
>> binary distro includes the site, which itself includes some
>> documentation beyond what is in the javadoc.  Personally, I liked the
>> old m1 way better where we bundled the site with the binary distro.
>> If we don't do that with the m2 releases, we need to make sure we have
>> working site builds in the source distros.  It would be nice to
>> include site build instructions in the release notes or a README as
>> well.
>>
>> The problem is in checkstyle.xml.  Looks like this has been fixed in trunk.
>>
>> Phil
>>
>>
>> >> There are 39 findbugs errors. They don't seem too important. Many are
>> >> serialization related (missing serialVersionUID, transient fields) and
>> >> many are style related (redeclaration of interfaces from superclass). I
>> >> think the errors in ContextBase and web.ChainListener are false
>> >> positive. The MTIA_SUSPECT_SERVLET_INSTANCE_FIELD may be more
>> >> problematic, I know nothing about servlets so cannot judge this. I'm
>> >> attaching the findbug.html report file to this message.
>> >
>> > I don't see it attached - also I added findbugs to the pom and ran it
>> > and didn't see such an error
>> >  http://svn.apache.org/viewvc?view=rev&revision=659363
>> >
>> > Niall
>> >
>> >> I don't cast any vote now, waiting for more knowledgeable people to look
>> >> at these servlet issues.
>> >>
>> >> Luc
>> >>
>> >> Oliver Heger wrote:
>> >>> +1
>> >>>
>> >>> Oliver
>> >>>
>> >>> Niall Pemberton wrote:
>> >>>> The main changes since RC1 are that the ant build now works on JDK
1.3
>> >>>> and the Logging dependency has been upgraded to the latest 1.1.1
>> >>>>
>> >>>> The artifacts are here:
>> >>>> http://people.apache.org/~niallp/chain_1_2_RC2/<http://people.apache.org/%7Eniallp/chain_1_2_RC2/>
>> >>>>
>> >>>> SVN Tag:
>> >>>> http://svn.apache.org/viewvc/commons/proper/chain/tags/CHAIN_1_2_RC2/
>> >>>>
>> >>>> Site:
>> >>>> http://people.apache.org/~niallp/chain_1_2_RC2/site/<http://people.apache.org/%7Eniallp/chain_1_2_RC2/site/>
>> >>>> (note m2 generates relative links, so some don't work - but the
site
>> >>>> is for info and not included in the release artifacts)
>> >>>>
>> >>>> Release Notes:
>> >>>> http://people.apache.org/~niallp/chain_1_2_RC2/RELEASE-NOTES.txt<http://people.apache.org/%7Eniallp/chain_1_2_RC2/RELEASE-NOTES.txt>
>> >>>>
>> http://people.apache.org/~niallp/chain_1_2_RC2/site/changes-report.html<http://people.apache.org/%7Eniallp/chain_1_2_RC2/site/changes-report.html>
>> >>>>
>> >>>> RAT Report:
>> >>>> http://people.apache.org/~niallp/chain_1_2_RC2/site/rat-report.html<http://people.apache.org/%7Eniallp/chain_1_2_RC2/site/rat-report.html>
>> >>>>
>> >>>> CLIRR Report:
>> >>>> http://people.apache.org/~niallp/chain_1_2_RC2/site/clirr-report.html<http://people.apache.org/%7Eniallp/chain_1_2_RC2/site/clirr-report.html>
>> >>>>
>> >>>> RC2 has been built with m2 - but m1 and ant builds are available
-
>> details here:
>> >>>> http://people.apache.org/~niallp/chain_1_2_RC2/site/building.html<http://people.apache.org/%7Eniallp/chain_1_2_RC2/site/building.html>
>> >>>>
>> >>>> Note: Chain is targetted at JDK 1.3, but I built with JDK 1.5 because
>> >>>> of the issue with m2 and JDK 1.4 - but I have tested on JDK 1.3
and
>> >>>> JDK 1.4 using m1 & ant and JDK 1.5 and JDK 1.6 using m2
>> >>>>
>> >>>> Vote is open for 72 hours
>> >>>>
>> >>>> Thanks in advance for your feedback/votes.
>> >>>>
>> >>>> Niall
>> >>>>
>> ------------------------------------------------------------------------------------------------------------->
>> >>>>
>> >>>> [  ] +1  I support this release
>> >>>> [  ] +0  I am OK with this release
>> >>>> [  ] -0   OK, but....
>> >>>> [  ] -1   I do not support this release
>> >>>>
>> >>>> ---------------------------------------------------------------------
>> >>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >>>> For additional commands, e-mail: dev-help@commons.apache.org
>> >>>>
>> >>>
>> >>>
>> >>> ---------------------------------------------------------------------
>> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >>> For additional commands, e-mail: dev-help@commons.apache.org
>> >>>
>> >>
>> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >>
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> > For additional commands, e-mail: dev-help@commons.apache.org
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message